• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43490031978
96%

Build:
DEFAULT BRANCH: main
Ran 13 Nov 2026 07:22PM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Nov 2026 07:12PM UTC coverage: 92.741% (+0.03%) from 92.711%
43490031978

push

github

web-flow
Password panel: don't delete a field row while it is being dragged (#2139)

* Password panel: don't delete a field row while it is being dragged

Dragging a shown field value (the password, or the OTP code label) onto the
search box crashed about half the time. clear() destroyed the field rows
with a plain delete, but a drag runs QDrag::exec() inside the value widget's
own mouse handler, and clear() is reached from that nested loop (a drop on
the search box, the panel autoclear timer, a second "qtpass NAME"). The row
was freed under its own handler and the handler went on using it
(use-after-free, SIGSEGV).

A row that has a QDrag among its children is now taken out of the grid and
hidden at once, and deleted with deleteLater() when that QDrag is destroyed,
which Qt does after the drag ends; rows with no drag are deleted at once as
before. deleteLater() alone is not enough: the drag's own event loop would
deliver it. Adds a passworddisplaypanel regression test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Test: flush deferred deletions so deleteLater() alone would fail

Per review: the liveness check also passed for a plain hide()+deleteLater(),
since the deferred deletion had not run yet. Deliver DeferredDelete events
while the drag is still alive before checking the row survives, so the test
proves the row is held by the drag-destruction connection.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

10464 of 11283 relevant lines covered (92.74%)

403.47 hits per line

Jobs
ID Job ID Ran Files Coverage
1 43490031978.1 13 Nov 2026 07:22PM UTC 127
92.74
GitHub Action Run
Source Files on build 43490031978
  • Tree
  • List 127
  • Changed 2
  • Source Changed 1
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43490031978
  • a00244a6 on github
  • Prev Build on main (#43483246073)
  • Next Build on main (#43493805190)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc