penguinolog / urwid / 43467036603

94%

Build Type

push

github

Committed by web-flow

Commit Message

Accept relative, pack and aligned pop-up sizes (#1652)

* Accept relative, pack and aligned pop-up sizes

set_pop_up() raised TypeError for any size that was not an int, so the
relative sizes that worked up to 4.0.12 crashed.

- An invalid size or position now raises CanvasError naming what was passed.
- A size can be cells, ("relative", percentage) with an int or float
  percentage, or "pack" for the size of the pop-up widget itself.
- left and top can be an alignment inside the whole PopUpTarget, applied once
  the size is known, so a packed dialog can be centred.
- PopUpTarget resolves relative and pack sizes before anchor placement; a
  packed widget without box sizing is shown through a top-aligned Filler, so
  rows that do not fit are cut off instead of covering the anchor rows.
- The calc theme pop-up uses a pack height instead of counting its rows.

The validation, the size resolution and their docstrings share the same
lines, so the fix and the new forms are one commit.

* Map Filler clicks to rows shown after cursor trim

Filler.render trims the top of a flow body taller than the box so that the
cursor row stays visible, but mouse_event and move_cursor_to_coords passed
the row on unshifted, so a click on a shown row reached a row above it.

- Both now add the rows render trimmed, computed by the same function.
- A packed pop-up that is cut off is shown through such a Filler, so a click
  in it now reaches the item it shows.

* Test packed pop-up reuse, nesting and alignment

Coverage Stats

7156 of 7826 branches covered (91.44%)

Branch coverage included in aggregate %.

87 of 90 new or added lines in 3 files covered. (96.67%)

214 existing lines in 7 files now uncovered.

18443 of 19458 relevant lines covered (94.78%)

15.0 hits per line