penguinolog / urwid / 43218109782

94%

push

github

Support in-band resize notifications (DEC private mode 2048) (#1643)

* Accept every in-band resize report form mode 2048 allows

The window size report decoder (CSI 48 ; rows ; cols ; height ; width t)
rejected reports a conforming terminal may send.

- Sub-parameters after a colon are ignored, as the mode asks of a client.
- The pixel size may be left out; when present it is skipped unread,
  so pixel values above 16 bits are accepted.
- A row or column count of 0 or above 65535 makes the report invalid,
  so a forged report cannot make the layout allocate an absurd canvas.

* Use in-band resize notifications in the raw display

A terminal with DEC private mode 2048 (kitty, foot, ghostty, iTerm2,
contour) reports each size change in the input. The resize then keeps its
place among the keys, and the size also reaches the program over links
that carry no SIGWINCH: a serial console, telnet, a raw socket.

- raw.Screen(in_band_resize=None) queries the mode and turns it on when
  the terminal can set it; True or False forces it. It is turned off at
  stop, and so around a suspend.
- A report becomes the size get_cols_rows() returns, until the next
  SIGWINCH makes the device size current again.
- A report is a "window resize" at its place among the keys only when its
  size differs from the one get_cols_rows() last returned, so the report
  sent when the mode is turned on, or after a SIGWINCH already reported,
  does not redraw again. A pending SIGWINCH is still reported on its own.
- iTerm2 3.5.6 to 3.5.10 send the report without its final byte, so the
  mode is not queried there.
- The Windows screen accepts the argument with no effect: its console
  reader already reports every resize in order, and each of its reports
  is a resize.

* Support in-band resize and DECRQM in the Terminal widget

A program inside a Terminal can now use DEC private mode 2048, and find
the modes the Terminal supports.

- Setting mode 2048 answers with a window size report o... (continued)

7098 of 7764 branches covered (91.42%)

Branch coverage included in aggregate %.

142 of 146 new or added lines in 6 files covered. (97.26%)

18315 of 19325 relevant lines covered (94.77%)

15.0 hits per line