penguinolog / urwid / 43210591707

94%

Build Type

push

github

Committed by web-flow

Commit Message

Apply Terminal reverse video when the content is drawn (#1641)

Each change of DECSCNM (CSI ? 5 h / l) rewrote every cell of both screens,
parsing a new AttrSpec per cell, so child output that toggles the mode
stalled the event loop for seconds per 4 KiB read.

- The mode is only the TermModes.reverse_video flag; a change touches no cell.
- TermCanvas.content() yields the attributes in standout while the flag is set,
  reversing each distinct attribute once per call, the scrollback view included.
- csi_set_attr() stores the attribute the child set.
- Text written after the mode is set is shown reversed, SGR 7 text keeps its
  standout when the mode is reset, and the scrollback view follows the mode.
- TermCanvas.reverse_video() only sets the flag and is deprecated
  (PendingDeprecationWarning), to be removed in 8.0.
- _deprecation.warn() takes a keyword-only category for the quiet stage.
- test_reverse_video_covers_both_screens reads the rendered content, since the
  stored cells no longer carry the reversal; it still checks both screens.

| what (600 bytes, 100 mode changes) | avg time before | avg time after | percent change |
| --- | --- | --- | --- |
| TermCanvas.addstr (via set_mode), 80x24 | 7.0 ms | 0.003 ms | -99.96% |
| TermCanvas.addstr (via set_mode), 200x60 | 44.6 ms | 0.003 ms | -99.99% |

Coverage Stats

7037 of 7692 branches covered (91.48%)

Branch coverage included in aggregate %.

19 of 21 new or added lines in 2 files covered. (90.48%)

284 existing lines in 13 files now uncovered.

18181 of 19190 relevant lines covered (94.74%)

15.03 hits per line