wol-soft / php-json-schema-model-generator / 43168501062

99%

master: 99%

push

github

Check composition branch types against the declared property type

A property which declares a type and carries an allOf, anyOf or oneOf
derived its type from the branches only and replaced the declared type.
A branch type which does not overlap the declared type was accepted at
generation time and the property then rejected every value.

- allOf: a branch type disjoint from the declared type throws a
  SchemaException naming the declared type and the branch. The branch
  contradiction check keeps precedence when the branches conflict among
  themselves.
- anyOf/oneOf: a disjoint branch is reported with a warning, a
  SchemaException is thrown when no branch overlaps the declared type.
  The property type is narrowed to the overlap instead of replaced.
- The declared type is read from the schema's type keyword, so filters
  do not change the comparison. Schemas which become a class are read as
  object. Implicit null widens the declared type for optional properties
  only. integer is a subtype of number.
- A number property narrowed to int drops its int to float cast and
  float type check, including the cast of number branches, which
  previously made an integer branch reject the integer value 42.
- The root level case reports the conflict instead of the unrelated
  "No nested schema for composed property" failure.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012uTHFTGTbBWMdC8H9S6QXj

179 of 179 new or added lines in 6 files covered. (100.0%)

10479 of 10556 relevant lines covered (99.27%)

609.17 hits per line