wol-soft / php-json-schema-model-generator / 43127752676

99%

master: 99%

push

github

Re-validate object-level not on updates and stop promoting not-required properties

An object-level `not` composition cached the result of its branch and only
evaluated it again if an update changed one of the branch's affected
properties. Compositions which don't transfer their branch properties to
the schema (not) never registered any, so the cached "branch didn't match"
result was reused forever: a setter or populate() making the branch match
(e.g. adding the property the branch requires) was accepted although the
constructor rejects the resulting data. The branch properties are now
registered as affected without transferring them to the schema.

While reproducing this, a second bug surfaced: the required promotion
treated a `required` inside a `not` branch like an anyOf/oneOf requirement
and made the property non-nullable, although such a branch guarantees the
property is absent. Its getter threw a TypeError for every valid object.
Promotion now uses an allow list (allOf, anyOf, oneOf, if/then/else).

Also adds regression tests for the schema dependency, maxProperties and
propertyNames updates, which the earlier rollback work already fixed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012uTHFURgEzL8Sj38Gzuwce

20 of 20 new or added lines in 2 files covered. (100.0%)

10335 of 10404 relevant lines covered (99.34%)

616.49 hits per line