wol-soft / php-json-schema-model-generator / 43121811643

99%

master: 99%

Pull #206

github

Remove the early return from the additional properties field declaration

The return was reached only by a class which takes a base-level $ref to a schema with an additionalProperties validator while AdditionalPropertiesAccessorPostProcessor(true) is registered: the internal post processor declares the field because of the transferred validator, the accessor post processor declares it again because the class's own JSON lacks the keyword. A schema which spells the keyword never reaches the accessor's call, so the comment describing that case named a path which does not exist.

The return changed nothing observable. The second registration of the property is a no-op in PropertyMerger (the first one is root-registered and both are arrays), so the generated class is identical with and without it. A test pins the combination: the second registration must stay unreported, the field must be declared, and the transferred validator must keep validating the additional properties.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

450 of 450 new or added lines in 22 files covered. (100.0%)

10634 of 10700 relevant lines covered (99.38%)

619.48 hits per line