accordproject / concerto-codegen / 43021014008

98%

push

github

fix(xmlschema): declare map types so map references resolve (#308)

Any model with a map declaration produced an XML Schema that did not
compile:

- the entry element of a map referred to <Map>EntryType without a
  namespace prefix, which resolves to no namespace because the schema
  has a targetNamespace and no default namespace
- a map was written as an element with an anonymous type, while fields
  of that map type refer to a type named after the map, which did not
  exist
- class and enum map values were prefixed with the namespace of the map
  instead of the namespace that declares them, so imported types did
  not resolve

Write a map declaration the same way a concept is written: a named
xs:complexType, then an xs:element of that type. Qualify the entry type
reference in the declaration and in the inline type written for map
fields with a size validator, and resolve class and enum key and value
types to their fully qualified name. This also covers the system types
(Concept, Asset, ...), which were special-cased before. Drop the now
unused mapElement argument of toXsType.

Closes #305

Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>
Signed-off-by: Matt Roberts <7544022+mttrbrts@users.noreply.github.com>
Co-authored-by: Matt Roberts <7544022+mttrbrts@users.noreply.github.com>

1734 of 1805 branches covered (96.07%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

3253 of 3274 relevant lines covered (99.36%)

9926.63 hits per line