accordproject / concerto-codegen / 42991590404

98%

push

github

fix(xmlschema): write optional properties with minOccurs="0" (#307)

XmlSchemaVisitor ignored isOptional(), so every optional field and
relationship was written as a plain xs:element. XSD defaults minOccurs
to 1, which made optional properties required: an instance leaving out
an optional property failed validation.

- Write minOccurs="0" for optional fields and relationships, and on the
  wrapper element of an optional map field with a size validator.
- Optional arrays always get minOccurs="0", even when their size
  validator has a minimum, because an absent array is valid.
- Pass the property's optional modifier into visitField for scalar
  fields. The field returned by getScalarField() does not carry it.
- Move the occurrence attribute logic shared by fields and
  relationships into a toOccurs helper.

Closes #304

Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>

1738 of 1809 branches covered (96.08%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

3255 of 3276 relevant lines covered (99.36%)

9919.1 hits per line