sds / overcommit / 42772037897

100%

master: 91%

push

github

Honor Git cleanup rules for comment-prefixed commit messages (#929)

Commit-message hooks always removed comment-prefixed lines, causing `git
commit -m '#16: ...'` to fail `EmptyMessage` even when Git would
preserve the title. Honor Git's effective cleanup mode when filtering
comments, so hooks see those titles while messages that become empty
under stripping cleanup are still rejected.

Closes #736.

Resolve command-line `--cleanup` overrides before `commit.cleanup`, and
use Git's documented `GIT_EDITOR=:` marker for the editor-dependent
default. Cache that result within the commit-message context. On
Windows, follow the `env.exe` launcher to the invoking Git process in
the COM, Script Host, and PowerShell query paths, so command-line
overrides are visible. Alternate comment characters and existing
verbose-diff filtering continue to work.

Adds unit and installed-hook integration tests for the scenarios in
#736: default `-m`, alternate comment characters, configured and
explicit whitespace cleanup, quoted Windows options, overrides
before/after the message, verbatim cleanup, editor-based commits, and
empty-message rejection. Integration tests check the final message
stored by Git.

Validation: all 1,844 local RSpec examples pass; pre-commit checks and
RuboCop pass. GitHub CI will verify Ruby 3.3/3.4/4.0 on Ubuntu and
Windows.

References: [Git commit cleanup
modes](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---cleanupltmodegt),
[Git hook editor marker](https://git-scm.com/docs/githooks#_pre_commit).

22 of 22 new or added lines in 3 files covered. (100.0%)

3451 of 3697 relevant lines covered (93.35%)

2501.07 hits per line