sds / overcommit / 42770188652

100%

master: 91%

push

github

750: Teach ad-hoc hooks line parsing (#757)

Command hooks can now parse file diagnostics through YAML configuration,
enabling Overcommit's existing warning and modified-line handling
without a Ruby plugin.

Closes #750. Implements the requirements and review decisions from that
issue:

- An explicit `message_pattern` Ruby regex enables parsing; a named
`file` capture is required, while `line` and `type` are optional.
- `warning_message_type_pattern` accepts a regex or literal substring;
unmatched or missing types default to errors.
- Commands receive applicable files and respect `include`, `exclude`,
`requires_files`, and `problem_on_unmodified_line`.
- Existing command hooks retain their Git-hook behavior. Only stdout is
parsed; tools using stderr can redirect it in a wrapper, as agreed in
review. Prefiltering and stream-selection options remain outside this
change.

Also fixes regex loading with current Psych versions, prevents failed
commands with empty/blank stdout from passing, validates patterns, and
avoids stale behavior when the same hook name is loaded with different
configuration. Documentation includes the GNU/Emacs-style example and
the failure behavior.

Validation: full local suite passed (1,813 examples); all 37 focused
loader/configuration examples pass, including a real subprocess with
staged files and Windows drive-letter diagnostics. Pre-commit checks and
RuboCop pass. GitHub CI covers Ruby 3.3, 3.4, and 4.0 on Ubuntu and
Windows.

---------

Co-authored-by: Shane da Silva <shane@dasilva.io>

36 of 36 new or added lines in 4 files covered. (100.0%)

3434 of 3680 relevant lines covered (93.32%)

2390.4 hits per line