• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

open-quantum-safe / liboqs / 42725440927
80%

Build:
DEFAULT BRANCH: main
Ran 10 Nov 2026 12:10AM UTC
Jobs 3
Files 2177
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

10 Nov 2026 12:04AM UTC coverage: 79.752% (-0.02%) from 79.771%
42725440927

push

github

web-flow
fix(sha3): align XKCP extraction parameters with dispatch header (#2652)

* fix(sha3): align XKCP extraction parameters with dispatch header

Fixes #2644 by adding the missing const qualifier to the state parameter in PlSnP-Fallback.inc to prevent UBSan function signature mismatches.

Signed-off-by: AKG451 <akg451154@gmail.com>

* Make the XKCP const fix in the patch set and avoid -Wcast-qual

The previous commit edited the generated PlSnP-Fallback.inc directly, so
the next XKCP re-import (scripts/copy_from_xkcp/package.sh) would revert
it: the liboqs patch for this file strips upstream's const from
PlSnP_ExtractLanesAll and PlSnP_ExtractAndAddLanesAll.

Make the change in scripts/copy_from_xkcp/patches/ instead, and
regenerate the file from it:

- Drop the hunks that removed const from the two LanesAll functions,
  so they match upstream again.
- Add const to PlSnP_ExtractBytes. It is called through
  KeccakX4ExtractBytesFn in xkcp_dispatch.h, and this is the mismatch
  that -fsanitize=function reports.
- Add a const-preserving constStateWithIndex() and use it in those
  three functions. stateWithIndex() casts to unsigned char *, so each
  newly const parameter produced a -Wcast-qual warning.
- Leave PlSnP_ExtractAndAddBytes as upstream has it (void *). It is not
  called through a function pointer.

package.sh copies .inc files without astyle or unifdef, so the upstream
file was recovered exactly by reverse-applying the old patch to the
committed file. Regenerating also restores the trailing newline.

Tested with Homebrew clang 23.1.4, Debug, USE_SANITIZER=Undefined and
UBSAN_OPTIONS=halt_on_error=1. Before this PR, test_sha3, test_kem
ML-KEM-768 and test_sig ML-DSA-65 abort at xkcp_sha3x4.c:144. After it
they pass, with no -Wcast-qual warnings from PlSnP-Fallback.inc. The
Release disassembly of KeccakP-1600-times4-on1.c.o is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

-... (continued)

2 of 6 new or added lines in 1 file covered. (33.33%)

65 existing lines in 11 files now uncovered.

169961 of 213112 relevant lines covered (79.75%)

5707801.94 hits per line

Uncovered Changes

Lines Coverage ∆ File
4
27.42
0.0% src/common/sha3/xkcp_low/KeccakP-1600times4/serial/PlSnP-Fallback.inc

Coverage Regressions

Lines Coverage ∆ File
18
70.59
-26.47% src/kem/ml_kem/mlkem-native_ml-kem-768_x86_64/mlkem/src/sampling.c
17
63.1
-20.24% src/kem/ml_kem/mlkem-native_ml-kem-512_x86_64/mlkem/src/sampling.c
15
91.94
-2.69% src/sig/sqisign/the-sqisign_sqisign_common/qlapoty.c
4
87.03
-1.08% src/sig/sqisign/the-sqisign_sqisign_common/primality_test.h
3
75.22
-2.65% src/kem/hqc/pqc-hqc_hqc-1_ref/vector.c
2
64.98
0.0% src/sig/ml_dsa/mldsa-native_ml-dsa-87_aarch64/mldsa/src/sign.c
2
92.98
-3.51% src/sig/ml_dsa/mldsa-native_ml-dsa-87_aarch64/mldsa/src/packing.c
1
94.74
0.0% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/packing.c
1
94.74
-1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/packing.c
1
94.74
-1.32% src/sig/uov/pqov_ov_Is_pkc_skc_avx2/ov.c
1
94.74
-1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-65_ref/mldsa/src/packing.c
Jobs
ID Job ID Ran Files Coverage
1 x64-generic - 42725440927.1 10 Nov 2026 12:34AM UTC 1013
84.33
GitHub Action Run
2 arm64-distbuild - 42725440927.2 10 Nov 2026 12:23AM UTC 1433
59.88
GitHub Action Run
3 x64-distbuild - 42725440927.3 10 Nov 2026 12:10AM UTC 1749
53.26
GitHub Action Run
Source Files on build 42725440927
  • Tree
  • List 2177
  • Changed 28
  • Source Changed 1
  • Coverage Changed 28
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42725440927
  • f47aaf55 on github
  • Prev Build on main (#42703200544)
  • Next Build on main (#43471410969)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc