IJHack / QtPass / 42702176309

93%

Build Type

push

github

Committed by web-flow

Commit Message

Bind a signed .gpg-id to its store, not only to its folder (#2124)

* Bind a signed .gpg-id to its store, not only to its folder

#2050: one signing key may sign the recipient lists of several stores,
and an authentic list of one, copied into another at the same folder,
verified there too; with a higher generation it was accepted, and QtPass
encrypted that store's entries to the other store's recipients.

A list QtPass writes for a signed store now carries a third signed
comment line, "# QtPass-GpgId-Store: <id>", a random 128-bit id given
when the store's first signed list is written. Each device remembers the
id it first saw per store in the generation record (outside the store,
next to the generations; format 1 still, older readers ignore the new
"stores" object), and GpgIdGeneration::accept() refuses, as WrongStore:

- a list whose store line names another id, before the staleness check,
  so another store's older list never reaches the Users dialog as this
  folder's rollback;
- a new list without a store line once the store has an id. A list this
  device accepted before keeps working, and a headerless list (pass) is
  as before.

Writers take the id from GpgIdGeneration::storeIdFor(): the one this
device knows, else the one on the verified list being replaced (a device
joining a store takes its id over), else a new one. SECURITY.md has the
binding and its limits (first sight, pass-written lists); the CHANGELOG's
upgrade notes ask signed teams to update together, since a list saved by
2.0-rc3 or older is refused once a device knows the store's id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* chore: update localization source references

make lupdate for the store-binding messages; location lines move only
for the files this branch changes, build-generated ones stripped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com... (continued)

Coverage Stats

129 of 136 new or added lines in 3 files covered. (94.85%)

2 existing lines in 1 file now uncovered.

10391 of 11206 relevant lines covered (92.73%)

403.37 hits per line