• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / remark42 / 42590926362
87%

Build:
DEFAULT BRANCH: master
Ran 09 Nov 2026 09:10AM UTC
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Nov 2026 09:07AM UTC coverage: 85.333% (+0.4%) from 84.983%
42590926362

push

github

web-flow
Share one import loop between importers and refuse unreadable exports (#2292)

* Share one import loop between the Disqus, WordPress and Commento importers

Each importer cleared the site, then read comments from a channel that
its converter filled in a goroutine. A converter stopped quietly at the
first input it could not read, so an unreadable or truncated export
reported success after the site had already been emptied.

The importers now share importComments. Each converter reads its export
synchronously, passes comments to a callback and returns an error when
the input cannot be read to the end. The site is cleared when the first
comment arrives, or once an export without comments has been read
completely. A converter also rejects input that is not its export: the
Disqus one requires the export's root element, the WordPress one an rss
document with wp:wxr_version, the Commento one its comments and
commenters lists, so an empty body, a plain RSS feed or a file in
another format is refused. An export whose records all fail to
decode is refused too. An input that cannot be read at all leaves the
site as it was; a truncated export keeps the comments read before the
break and reports the error.

The Commento converter also logged every comment URL at ERROR level,
and when a URL could not be built it called Error on a nil error, which
would have crashed the server.

The bad record in the Disqus test exports had an unquoted attribute,
which made the rest of the file unreadable; it is quoted now, so the
record is still rejected for its values. The Markdown WordPress test
export gains its missing opening rss element and the wp:wxr_version
element every WordPress export carries.

* Flush the site cache after a failed import or remap

An import that failed after clearing the site, either a provider import
or the native import a remap runs, left the cached listings of the old
comments in place. The cache is now flushed whether or not the import
succeeds.

* R... (continued)

209 of 232 new or added lines in 5 files covered. (90.09%)

4 existing lines in 3 files now uncovered.

6208 of 7275 relevant lines covered (85.33%)

33.64 hits per line

Uncovered Changes

Lines Coverage ∆ File
9
77.55
-11.34% backend/app/migrator/migrator.go
8
84.62
4.33% backend/app/migrator/commento.go
3
95.74
9.57% backend/app/migrator/disqus.go
3
93.1
13.84% backend/app/migrator/wordpress.go

Coverage Regressions

Lines Coverage ∆ File
2
84.62
4.33% backend/app/migrator/commento.go
1
95.74
9.57% backend/app/migrator/disqus.go
1
93.1
13.84% backend/app/migrator/wordpress.go
Jobs
ID Job ID Ran Files Coverage
1 42590926362.1 09 Nov 2026 09:10AM UTC 54
85.33
GitHub Action Run
Source Files on build 42590926362
  • Tree
  • List 54
  • Changed 5
  • Source Changed 0
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • b1d4d9d1 on github
  • Prev Build on master (#42590843476)
  • Next Build on master (#42591310903)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc