• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / remark42 / 42590843476
87%

Build:
DEFAULT BRANCH: master
Ran 09 Nov 2026 09:09AM UTC
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Nov 2026 09:06AM UTC coverage: 84.983% (+0.2%) from 84.794%
42590843476

push

github

web-flow
Reject incomplete tokens and use the checked site in email handlers (#2289)

* Reject tokens without a handshake or user instead of panicking

Email confirmation and the unsubscribe link read the address from the
token's handshake, and the delete-me link reads the user from its
token. Any valid token without that part, such as a login token, made
the handler dereference nil and answer 500. The admin user-info
handler also passed a nil error on when an engine returned no comments
without an error, which a remote engine does for an unknown user.

The confirmation and unsubscribe handlers now share one parser that
rejects a token without a handshake with 400, the delete-me handler
refuses a token without a user with 403, and an empty user-info result
gets its own error.

* Subscribe and confirm email on the site checked for the session

The site check middleware compares the session's site with the site in
the query, but email subscribe and confirm used the site from the
request body. A reader could name another site of the same instance in
the body and change their email subscription there.

Both handlers now use the site from the query, which the widget and the
documented API always send. The body's site is used only when the query
has none, which only the basic-auth admin can reach.

* Handle tokens without a user when updating the email, keep addresses out of errors

The admin password sent along with a token that has no user, such as a
confirmation token, passes authentication. Setting or deleting the email
then read the user from that token to update it and dereferenced nil,
answering 500 after the change was already stored. Such a token has no
email to update, so the change now succeeds without touching it.

A handshake that did not split into user and address was echoed whole
into the error sent back and logged, and it carries the address. The
error now says only that the handshake is malformed.

* Reject handshakes with an empty user or address
... (continued)

38 of 44 new or added lines in 2 files covered. (86.36%)

6157 of 7245 relevant lines covered (84.98%)

32.89 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
77.94
2.39% backend/app/rest/api/rest_private.go
Jobs
ID Job ID Ran Files Coverage
1 42590843476.1 09 Nov 2026 09:09AM UTC 54
84.98
GitHub Action Run
Source Files on build 42590843476
  • Tree
  • List 54
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 0ab7b787 on github
  • Prev Build on master (#42590774773)
  • Next Build on master (#42590926362)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc