ruby-grape / grape / 42397174974

100%

push

github

Cascade past a mounted Rack app declining with lowercase x-cascade (#3064)

Router#cascade? looked up 'X-Cascade'. Grape's own responses fold the
case of a header name, but a mounted Rack app answers in a Hash of its
own, where case matters. On Rack 3 the SPEC requires lowercase names, so
an app declining with x-cascade: pass, as Sinatra and Rails do on Rack 3,
was never seen as declining: its own 404 reached the client instead of
the router's, and a sibling after it was never tried.

cascade? now reads x-cascade, and falls back to X-Cascade, the Rack 2
spelling, only for a Hash that does not fold case, so Grape's own
responses pay one extra is_a? check rather than a second lookup.

The router specs only ever declined with the Rack 2 spelling, which is
why this went unnoticed; one now declines with the Rack 3 spelling, and
an API spec mounts an app that does. The mounted-app "is able to
cascade" spec compared X-Cascade with == where it meant to set it, so it
tested nothing; it now sets x-cascade.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1531 of 1531 branches covered (100.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

4570 of 4570 relevant lines covered (100.0%)

30903.4 hits per line