ruby-grape / grape / 42374301247

100%

push

github

Load I18n before the translated-format spec stores its format (#3059)

The spec added in #3051 stores `grape.errors.format` with
`I18n.backend.store_translations`, which does not load the locale files.
When the backend has not loaded them yet (the example runs first, or
right after another spec's `I18n.reload!`), the first lookup loads
en.yml over the stored translations and puts the default format back.
`format` is the only key a spec stores that en.yml also defines, so this
example is the only one affected. It fails on its own
(`rspec spec/grape/exceptions/validation_errors_spec.rb:85`) and under
seed 28071, which failed the rails_7_2 job on #3054.

`I18n.backend.translations(do_init: true)` loads en.yml before the
override is stored. `eager_load!` would too, but it also leaves the
backend flagged as eager-loaded for the rest of the run, so every later
`I18n.reload!` reloads at once, under whatever locales the spec has set
at that moment. base_spec's `after { I18n.reload! }` runs while
`available_locales` is `[:de, :jp]`, so the reload skipped `:en`, and
every translation after it came back as its key: 1 to 80 failures
depending on the seed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1529 of 1529 branches covered (100.0%)

Branch coverage included in aggregate %.

4567 of 4567 relevant lines covered (100.0%)

30874.42 hits per line