• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stillwater-sc / universal / 42312921512
89%
master: 84%

Build:
Build:
LAST BUILD BRANCH: fix/fixpnt-quire-resolve-saturates
DEFAULT BRANCH: master
Ran 06 Nov 2026 11:52PM UTC
Jobs 1
Files 868
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Nov 2026 11:35PM UTC coverage: 88.634% (-0.002%) from 88.636%
42312921512

push

github

web-flow
fix(rational): parse the most negative value (#1976)

rational<8, base2, uint8_t> rejected "-128" although it holds -128
(QA sweep #1962). The parse accumulated the magnitude, 1, 12, 128, and
negated at the end, but in two's complement the most negative value
has no magnitude: 12*10 + 8 wraps to -128, and the overflow guard
rejected it.

The digits now accumulate with the number's sign, -1, -12, -128, so
the most negative value is reached directly. append_digit and
scale_by_ten take the sign, and their wrap check looks for a result on
the wrong side of zero for that sign. The undo check is unchanged.
The denominator of n/d stays unsigned, so "-128/128" still fails in 8
bits.

static/rational/binary/conversion/stream_input.cpp now covers:
- "-128", "-129", "-1.28e2", "-12.8e1", "-128/2" and "-128/128" for
  rational<8>;
- every integer to past each type's range, asymmetric as two's
  complement is (-32768 for rational<16>);
- the n/d round trip down to the numerator -128.
Negative scaling is covered too: "-1e1" and "-3.5e2" in all four
bases, and "-1.3e2", whose scaling wraps (CodeRabbit). main's parse
fails 133 of these checks. All 17 rational tests pass
with gcc and clang.

Relates to #1973
Relates to #1962

BEHAVIOUR-CHANGE: rational parse() and operator>> now accept the type's most negative integer (-128 in rational<8>, -32768 in rational<16>), which they rejected

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

14 of 14 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

59092 of 66670 relevant lines covered (88.63%)

9661307.36 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
34.7
-0.63% include/sw/universal/verification/test_suite_randoms.hpp
1
93.16
-0.85% include/sw/universal/verification/correctly_rounded_reference.hpp
Jobs
ID Job ID Ran Files Coverage
1 42312921512.1 06 Nov 2026 11:52PM UTC 868
88.63
GitHub Action Run
Source Files on build 42312921512
  • Tree
  • List 868
  • Changed 4
  • Source Changed 1
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42312921512
  • b5eaec8b on github
  • Prev Build on main (#42297712065)
  • Next Build on main (#42313599716)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc