nats-io / nats.js / 42252127330

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(core): a bad server info fails the connection early (#491)

an info the client can't parse or apply (malformed json, connect_urls
not an array or with an entry that doesn't parse, a bad version) now
fails the connection as soon as it arrives.

- the info dispatch catches the error and reports it as an error
  status with a ProtocolError naming the problem; the connect attempt
  rejects, or a live connection drops and the normal reconnect runs
  (or the client closes with reconnect: false)
- servers.update() checks connect_urls before applying any of it, so a
  bad entry is reported by name and the server list is left alone

Coverage Stats

5176 of 5920 branches covered (87.43%)

Branch coverage included in aggregate %.

41 of 41 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

12411 of 13315 relevant lines covered (93.21%)

173069.64 hits per line