nats-io / nats.js / 42245821407

91%

push

github

fix(core): bound the dns lookup by the connect timeout (#490)

a dns lookup that never settled stalled the dial loop: the connect
timeout only started after the lookup, so there was no timeout, no
retry, and a close() during the lookup didn't stop it.

- the lookup in _doDial races the connect timeout, its own wait of
  the same length; a timed out lookup fails the attempt and is retried
  like any other failed connect
- a close() during the lookup no longer goes on to dial
- parseOptions defaults timeout to 20000 when unset or 0 and rejects
  values that aren't positive numbers, so it always has a value;
  dial() no longer carries its own fallback
- docs: timeout also bounds the dns lookup

5111 of 5845 branches covered (87.44%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 2 files covered. (100.0%)

12370 of 13275 relevant lines covered (93.18%)

174049.93 hits per line