supabase / supabase / 42229551316

87%

push

github

fix(studio): show an error toast when deleting a JWT signing key fails (#53087)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

On the JWT Keys settings page, the delete mutation for a signing key is
called with a custom `onError` that only closes the dialog. A custom
`onError` replaces the hook's default error toast, so when the API
rejects the delete (for example a 422 for a revoked key that cannot be
deleted yet), the dialog closes and nothing tells the user why.

## What is the new behavior?

The custom `onError` still closes the dialog, and now also shows `Failed
to delete JWT signing key: <API error message>` as an error toast.

## How to verify

1. Open Project Settings > JWT Keys on a project with a revoked signing
key that the API refuses to delete.
2. Click Delete on the revoked key and confirm.
3. An error toast appears with the API's error message, and the dialog
closes.
4. Deleting a revoked key that the API accepts still shows "Successfully
deleted key" and removes it from the list.

## Checks run

- `pnpm turbo run lint --filter='[origin/master]'`
- Studio typecheck (`tsc --noEmit` in `apps/studio`; the turbo run ran
out of memory, the direct run passed)
- Prettier check on the changed file


[FE-4943](https://linear.app/supabase/issue/FE-4943/no-error-message-shown-when-deleting-revoked-jwt-key-fails)

Co-authored-by: supabase-vercel-tedd[bot] <336548405+supabase-vercel-tedd[bot]@users.noreply.github.com>

2049 of 2417 branches covered (84.77%)

Branch coverage included in aggregate %.

2846 of 3205 relevant lines covered (88.8%)

201.27 hits per line