supabase / supabase / 42224975896

87%

push

github

fix(studio): only show free Micro upgrade banner on paid plans (#53041)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

The project homepage shows the "free upgrade to Micro" banner
(`BannerFreeMicroUpgrade`) for any project on Nano compute that is near
resource exhaustion, regardless of the organization's plan. The free
Micro upgrade only applies to paid plans, so organizations on the Free
plan can see a banner offering something they are not eligible for.
`ComputeBadgeWrapper` already gates the equivalent upgrade glow on
`plan.id !== 'free'`.

## What is the new behavior?

`ProjectLayout` only shows the banner when the selected organization's
plan is known and is not `free`. The plan comes from the already-loaded
selected organization, so this adds no new request. While the plan is
unknown, the banner stays hidden.

## How to verify

- In a project of a Free plan organization on Nano compute with a
resource exhaustion warning, the project homepage does not show the free
Micro upgrade banner.
- In a project of a paid (Pro or higher) organization on Nano compute
with a resource exhaustion warning, the project homepage still shows the
banner.
- Projects not on Nano compute, or without exhaustion warnings, show no
banner, same as before.

## Checks run

- `pnpm turbo run typecheck --filter='...[origin/master]'`: pass
- `pnpm turbo run lint --filter='[origin/master]'`: pass
- Prettier check on the changed file: pass
- `vitest related` for the changed file could not run in the sandbox (it
stopped on a parse error in an unrelated static `.md` file before
reaching any test). No existing test covers this banner condition.


[FE-4366](https://linear.app/supabase/issue/FE-4366/free-micro-upgrade-banner-missing-plan-tier-gate-in-projectlayout)

---------

Co-authored-by: supabase-vercel-tedd[bot] <336548405+supabase-vercel-tedd[bot]@users.noreply.github.com>

2048 of 2417 branches covered (84.73%)

Branch coverage included in aggregate %.

2845 of 3205 relevant lines covered (88.77%)

201.27 hits per line