• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 42192547353
79%

Build:
DEFAULT BRANCH: development
Ran 06 Nov 2026 11:01AM UTC
Jobs 1
Files 802
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Nov 2026 09:06AM UTC coverage: 78.096% (+0.1%) from 77.991%
42192547353

push

github

web-flow
fix(validation): reject headers whose kernel MMR size does not grow (#8262)

Description
---
A header chain with a non-growing kernel MMR size was only rejected at
the end of horizon sync, after the kernel stream had stopped committing.
Header validation never related a header's `kernel_mmr_size` to its
parent's; the only check was at body validation, which a pruned node
does not run below its horizon. In `synchronize_kernels`, a header whose
size does not exceed the current position can never close, so the
remaining kernels accumulated in memory uncommitted and the function
returned `Ok(())`, leaving the failure to final horizon state
validation.

Every valid non-genesis block has exactly one coinbase kernel, and body
validation requires `kernel_mmr_size` to equal the kernel MMR leaf
count, so `kernel_mmr_size` must grow by at least one per block.

Changes:
- New `BlockHeaderValidationError::KernelMmrSizeNotIncreasing { prev,
actual }`.
- `HeaderFullValidator::validate` rejects a header unless
`kernel_mmr_size > prev_header.kernel_mmr_size`. The check runs after
proof of work (so headers without valid work are never recorded as bad
blocks) and before the Monero seed height check. The verdict is fixed by
the header and its `prev_hash`, so header sync records it in the bad
block list. No activation height: it only rejects headers whose blocks
are already invalid.
- `synchronize_kernels` returns `InvalidMmrPosition` when a kernel's
position is at or past the current header's `kernel_mmr_size`, and
`IncorrectResponse` when kernels are left uncommitted at the end of the
stream.

Motivation and Context
---
Fail early and explicitly instead of at final horizon validation, and
stop unverified kernels from accumulating in memory during kernel sync.

Notes:
- Mixed-version networks: an older node can hold a header above its
block tip that newer nodes reject under this rule, and serve it during
header sync; newer nodes then ban that peer. This is the same behav... (continued)

187 of 194 new or added lines in 5 files covered. (96.39%)

2000 existing lines in 16 files now uncovered.

145717 of 186586 relevant lines covered (78.1%)

1178998.46 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
66.39
1.24% base_layer/core/src/chain_storage/blockchain_database.rs
2
96.98
-0.25% base_layer/core/src/validation/header/header_full_validator.rs

Coverage Regressions

Lines Coverage ∆ File
961
66.39
1.24% base_layer/core/src/chain_storage/blockchain_database.rs
898
66.91
0.34% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
52
69.97
0.41% base_layer/core/src/chain_storage/db_transaction.rs
48
87.97
0.41% base_layer/core/src/test_helpers/blockchain.rs
9
86.47
0.23% base_layer/core/src/chain_storage/lmdb_db/stats_collector.rs
9
77.13
-0.14% comms/core/src/connectivity/manager.rs
6
85.45
-1.58% base_layer/core/src/base_node/state_machine_service/states/block_sync.rs
4
73.22
0.43% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
3
96.98
-0.25% base_layer/core/src/validation/header/header_full_validator.rs
2
94.23
0.07% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
2
77.55
0.15% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
2
82.81
-3.13% comms/core/src/pipeline/outbound.rs
1
93.27
-0.08% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
1
75.72
-0.22% base_layer/core/src/mempool/sync_protocol/mod.rs
1
93.23
-0.38% comms/core/src/connectivity/proactive_dialer.rs
1
92.71
0.39% comms/core/src/multiplexing/yamux.rs
Jobs
ID Job ID Ran Files Coverage
1 42192547353.1 06 Nov 2026 11:01AM UTC 802
78.1
GitHub Action Run
Source Files on build 42192547353
  • Tree
  • List 802
  • Changed 33
  • Source Changed 11
  • Coverage Changed 33
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42192547353
  • 27902317 on github
  • Prev Build on development (#42084326644)
  • Next Build on development (#42211089709)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc