• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 42084326644
79%

Build:
DEFAULT BRANCH: development
Ran 05 Nov 2026 08:16PM UTC
Jobs 1
Files 802
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Nov 2026 06:26PM UTC coverage: 77.991% (+0.04%) from 77.955%
42084326644

push

github

web-flow
fix(comms): apply the RPC client read deadline once per request (#8261)

Description
---
The RPC client now starts one read deadline per request and applies it
to every frame read for that request. That includes frames it ignores
because they carry the previous request's id.

- **`comms/core/src/protocol/rpc/client/mod.rs`**
- The deadline is an `Option<Instant>` owned by the request loop. The
first read sets it, each read uses `time::timeout_at` against it, and it
is cleared only after a response is accepted.
- Streaming responses still give each valid item its own deadline. The
server is also built around one deadline per item.
- The deadline starts after the client has room in its buffer, as
before, so a slow consumer doesn't use it up.
- Ping is unchanged. The cap of 20 ignored frames, its error, the config
and the server side are all unchanged.

Motivation and Context
---
The client started a fresh `rpc_deadline` timeout for every frame it
read. A frame tagged with the previous request id is ignored, up to 20
times, and each one restarted the timer. A server that interleaved such
late frames could therefore extend a single request far beyond
`rpc_deadline`, up to about 21 × (deadline + grace). This affects every
RPC client user: header, block and horizon sync, and wallet RPC.

How Has This Been Tested?
---
- New test `ignored_stale_responses_do_not_extend_the_deadline`: a raw
server sends 20 frames with the previous request id, 80 ms apart,
against a 100 ms deadline. The request must fail with `Timeout` in under
500 ms. On the old code it takes about 1.7 s, so the test fails there.
- New test
`a_stream_longer_than_the_deadline_completes_when_items_arrive_in_time`:
5 items 400 ms apart against a 1 s deadline still arrive in full. It
passes on the old and new code, which confirms per-item behaviour is
unchanged.
- `cargo nextest run -p tari_comms --all-features`: 484 passed.
- Commands run: `cargo +nightly ci-fmt-fix`, `cargo ci-clippy`, `cargo
ci-... (continued)

81 of 82 new or added lines in 2 files covered. (98.78%)

104 existing lines in 18 files now uncovered.

145288 of 186288 relevant lines covered (77.99%)

995596.83 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
99.1
-0.03% comms/core/src/protocol/rpc/test/smoke.rs

Coverage Regressions

Lines Coverage ∆ File
19
65.15
0.9% base_layer/core/src/chain_storage/blockchain_database.rs
19
77.26
-0.62% comms/core/src/connectivity/manager.rs
10
72.79
-0.43% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
8
87.63
-1.39% comms/core/src/connection_manager/dialer.rs
6
77.4
-0.12% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
6
92.31
-0.39% comms/core/src/multiplexing/yamux.rs
5
82.92
-0.31% base_layer/core/src/base_node/comms_interface/inbound_handlers.rs
5
94.15
0.09% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
5
87.45
-0.49% base_layer/core/src/proof_of_work/cuckaroo_pow.rs
5
85.61
0.63% comms/core/src/protocol/rpc/client/mod.rs
4
80.66
-0.41% comms/dht/src/connectivity/mod.rs
3
85.39
-1.12% base_layer/core/src/base_node/sync/rpc/sync_utxos_task.rs
3
91.26
-0.46% comms/core/src/connection_manager/listener.rs
2
88.71
-0.31% comms/core/src/connection_manager/peer_connection.rs
1
55.13
-1.28% base_layer/core/src/validation/error.rs
1
68.97
-0.49% comms/core/src/connectivity/requester.rs
1
87.65
0.0% comms/core/src/protocol/messaging/inbound.rs
1
90.76
-0.11% comms/dht/src/actor.rs
Jobs
ID Job ID Ran Files Coverage
1 42084326644.1 05 Nov 2026 08:16PM UTC 802
77.99
GitHub Action Run
Source Files on build 42084326644
  • Tree
  • List 802
  • Changed 30
  • Source Changed 2
  • Coverage Changed 30
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42084326644
  • fca5dd3e on github
  • Prev Build on development (#42017199593)
  • Next Build on development (#42192547353)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc