pmd / pmd / 930

80%

push

github

[kotlin] Add @TypeName to VariableDeclaration, fix destructuring type leak (#7168)

* [kotlin] Fix @TypeName leaking from first destructured component

val (a, b) = ... destructuring declarations recorded each component as a
separate kind=DESTRUCTURED_VARIABLE entry by kotlin-type-mapper, but
visitPropertyDeclaration matched any declaration on the same line
regardless of kind, so the whole PropertyDeclaration node picked up the
first component's type (e.g. kotlin.Int for 'a') instead of having no
type at all.

Filter to kind=PROPERTY, mirroring visitClassParameter, so destructuring
declarations correctly have no @TypeName on the whole node.

* [kotlin] Add @TypeName to VariableDeclaration, close typeIs/isNullable leak

Each VariableDeclaration in a property declaration now carries its own
@TypeName, including each component of a destructuring declaration
(val (a, b) = ...), so destructured variables can be found by type.

The line-based declaration fallback in typeIs/typeIsExactly/isNullable
ignored the destructuring fix on the attribute, still matching a
component's type on the whole PropertyDeclaration. Skip
DESTRUCTURED_VARIABLE declarations there for PropertyDeclaration nodes.

Extract annotatePropertyType() shared by PropertyDeclaration and
ClassParameter. Regenerate tree dumps, document in kotlin.md and
release notes.

* [kotlin] Add @TypeName to for-loop VariableDeclaration

Single for-loop variables (for (item in items)) now carry @TypeName on
their VariableDeclaration too. Destructured components only match their
own DESTRUCTURED_VARIABLE entry, so the enclosing for-loop parameter
(whose range also covers "(a, b)") can never be picked by ordering.

Add VariableTypes tree dump covering property, destructured, for-loop,
destructured for-loop and destructured lambda variables. Document
querying VariableDeclaration to find variables by type.

* [kotlin] Add @TypeName to explicitly typed lambda parameters

Match VariableDeclaration type info by na... (continued)

20636 of 26748 branches covered (77.15%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 4 files covered. (100.0%)

44028 of 53960 relevant lines covered (81.59%)

0.82 hits per line