RobotWebTools / rclnodejs / 41764787681

91%

push

github

Harden ready-batch dispatch and process-exit cleanup (#1666)

## Summary

Prevent callbacks from accessing stopped or destroyed ROS entities, and release native resources when callbacks throw or the process exits.

## Changes

- Track ready batches with `_dispatchGeneration`; increment it in `stop()`, `stopSpinning()`, and `destroy()` so an immediate restart cannot resume an invalidated batch.
- Check `event.isDestroyed()` before `takeData()` and recheck action entities between successive ready events.
- Run `Type.destroyRawROS()`, `GoalInfoArray.freeArray()`, and `Entity._gcHandles()` in `finally` blocks.
- Stop the batch at the first synchronous callback error, preserving the original thrown value. Document Node.js uncaught exception handling for `spin()` and direct propagation for `spinOnce()`.
- Register `process.once('exit', () => rcl.shutdownAll())` to shut down default and custom contexts before native teardown.
- Call `rcl_context_fini()` for initialized contexts even when an earlier `rcl_shutdown()` has already invalidated them.
- Test stale-batch rejection after stop/restart, destroyed event handlers, callback-error cleanup, and context shutdown on natural exit, `process.exit(7)`, and an unhandled callback error.
- Print child exit code, signal, sanitizer settings, stdout, and stderr when the unhandled-callback regression fails.

Fix: #1667

2359 of 2764 branches covered (85.35%)

Branch coverage included in aggregate %.

258 of 259 new or added lines in 2 files covered. (99.61%)

18124 of 19701 relevant lines covered (92.0%)

272.58 hits per line