microlinkhq / browserless / 41681087503

77%

push

github

fix(browserless): a call running when its context is destroyed does not retry (#1017)

* fix(browserless): a call running when its context is destroyed does not retry

destroyContext() closed the context without telling the retry loop, so
a call still running in it got a retryable error and opened a new
context nobody closed. Retry recovery could not tell a crash from a
deliberate destroy; only an opt-in force flag did.

Now a call that was running when destroyContext() happened aborts with
AbortError, and a non-retryable error still reaches the caller. A call
made after destroyContext() still opens a new context, and with a
credentialed proxyServer it now starts a new forwarder instead of
pointing Chromium at the one destroyContext() closed. force is
deprecated and has no effect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(browserless): open a destroyed context on demand and stop retrying once closed

- destroyContext() drops the context it closes, so a call that starts
  while it runs, or with retry: 0 right after it, opens a new context
  instead of hanging on, or failing against, the closing one.
- A retry after browser.close() aborts instead of opening a context
  with the raw proxyServer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(browserless): check for a destroyed context when each attempt starts

- p-retry waits between attempts, and a destroyContext() or close() in
  that wait went unseen: the next attempt opened a context nobody
  closed. Each attempt now checks before opening a page.
- The closed-browser check runs after the retryable check, so a
  non-retryable error during close reaches the caller unchanged.
- The html() abort test waits for a local server that never answers
  instead of example.com and a fixed delay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(browserless): reject a call that finishes after destroyContext

A call whose function resolved after destroyContext() ... (continued)

2202 of 2482 branches covered (88.72%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 1 file covered. (100.0%)

7820 of 10414 relevant lines covered (75.09%)

57716.07 hits per line