microlinkhq / browserless
81%

DEFAULT BRANCH: master
Repo Added
Files 48
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x

coverage: 80.577% (-0.05%) from 80.624%
36680925732

push

github

web-flow 
fix(function): resolve the supplied page without a CDP round trip (#952)

`resolvePage` opened a CDP session on every candidate page and asked it
`Target.getTargetInfo`. On the `getPage` path `strictTarget` is always
set, so the scan always ran, and `browser.pages()` is every page on that
browser rather than only ours.

Measured in production on `({ page }) => page.title()`, correlating the
page count the isolate sees against the time the snippet itself takes:

  pages=1  fn.run 80-118ms   (12 samples)
  pages=2  fn.run 473ms
  pages=2  fn.run 1747ms

One neighbour is enough. The cost is not the length of the list, it is
opening a session on somebody else's page and waiting on a target that
may be mid-navigation. Worst observed was 15055ms of `fn.run` for a
snippet whose only statement is `page.title()`, with the fetch, spawn and
build phases all normal.

The isolate already has the id locally. `page.target()._targetId` is
maintained from target events, needs no round trip, and matches
`page.mainFrame()._id`; both were confirmed against a production isolate
on `@cloudflare/puppeteer` 1.4.0.

The scan now reads that first and only falls back to asking over a
session when no page carries it, so a build where the private field
disappears still resolves rather than failing with PAGE_NOT_FOUND.

The three existing tests describe pages with no local id, so they now
cover the fallback. Three more cover the local path, a neighbour that
refuses a session, and the mixed case.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

1377 of 1619 branches covered (85.05%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 1 file covered. (100.0%)

8 existing lines in 1 file now uncovered.

5916 of 7432 relevant lines covered (79.6%)

67773.04 hits per line

Relevant lines Covered
7432 RELEVANT LINES 5916 COVERED LINES
67773.04 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
36680925732 master fix(function): resolve the supplied page without a CDP round trip (#952) `resolvePage` opened a CDP session on every candidate page and asked it `Target.getTargetInfo`. On the `getPage` path `strictTarget` is always set, so the scan always ran, a... push web-flow github
80.58
36680244787 master build(deps): bump ws from 8.21.3 to 8.22.0 (#951) Bumps [ws](https://github.com/websockets/ws) from 8.21.3 to 8.22.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/8.21.3...8.22.... push web-flow github
80.62
36679905467 Kikobeats/function-resolve-page-locally Merge 5cb774eae into 0fc0e3833 Pull #952 web-flow github
80.65
36667145970 dependabot/npm_and_yarn/ws-8.22.0 Merge 2e70862a0 into 0fc0e3833 Pull #951 web-flow github
80.62
36534255521 master feat(function): resolve page methods when the snippet asks for them (#950) * feat(function): resolve page methods when the snippet asks for them `extendPage` can only carry values decided before the snippet starts, so anything it might read had ... push web-flow github
80.62
36533508984 Kikobeats/function-lazy-page Merge 9453ef77b into 9b15762cb Pull #950 web-flow github
80.62
36482936012 Kikobeats/function-lazy-page Merge 8d193e38b into 9b15762cb Pull #950 web-flow github
80.61
36480003508 Kikobeats/function-lazy-page Merge 74bbea338 into 9b15762cb Pull #950 web-flow github
80.56
36390576218 master build(deps): bump @duckduckgo/autoconsent from 16.41.0 to 16.42.0 (#949) Bumps [@duckduckgo/autoconsent](https://github.com/duckduckgo/autoconsent) from 16.41.0 to 16.42.0. - [Release notes](https://github.com/duckduckgo/autoconsent/releases) - [... push web-flow github
80.47
36275597130 master feat(function): let a caller supply the page and keep the context (#948) * feat(function): let a caller supply the page and keep the context A request that runs a Function against a URL loads that URL twice. The HTML fetch navigates it in one co... push web-flow github
80.47
See All Builds (1397)