nats-io / nats.js / 41674524258

91%

push

github

fix(core): subscription timeouts behave the same for callbacks and iterators (#481)

the subscription timeout now matches its documentation for callback
subscriptions: the first message cancels the timer, as it already did
for iterators.

if the timeout expires, a callback subscription now closes like an
iterator one: the callback gets the TimeoutError, closed resolves with
it, and the subscription is unsubscribed. this also avoids an extra
UNSUB after a noMux request was answered.

a draining subscription no longer times out.

5114 of 5847 branches covered (87.46%)

Branch coverage included in aggregate %.

8 of 11 new or added lines in 1 file covered. (72.73%)

12075 of 13251 relevant lines covered (91.13%)

153015.1 hits per line