nats-io / nats.js / 41518984938

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: harden and make consistent user callback error handling (#480)

user code called by the client is now handled consistently depending
on the use case, and errors it raises are always contained by the
client, preventing unexpected side effects on a client that are not
easily understood.

a distinction is made between callbacks, which the client hands data
to, and providers, which supply something the client needs to continue.

- if a callback (subscriptions, consumers, direct get, service
  handlers) throws or rejects, the error is printed as an
  UnhandledCallbackError with where it failed and the thrown value as
  cause, and the client continues. consumers no longer stop, the
  unacked message is redelivered. services still reply 500 and record
  last_error.
- if a provider throws or rejects, the operation that needed it fails
  with the error (non-errors become an UnhandledCallbackError):
  - connection options authenticator, reconnectToServer,
    reconnectDelayHandler, waitOnFirstConnect: the client closes the
    connection with the error - on the first connect, connect() rejects
    with it.
  - requestMany strategy: only that request fails, the connection
    continues.
  - services statsHandler (service config): only the service's stats
    fail - stats() rejects and a $SRV STATS request gets a 500 - the
    service continues. previously the failure was counted and the stats
    sent without its data. it is also printed.
- status and closed() still report only server and protocol errors.

Coverage Stats

5102 of 5832 branches covered (87.48%)

Branch coverage included in aggregate %.

174 of 200 new or added lines in 12 files covered. (87.0%)

2 existing lines in 1 file now uncovered.

12067 of 13240 relevant lines covered (91.14%)

153084.27 hits per line