#20551
89%

Ran 03 Nov 2026 03:37AM UTC

Jobs 1

Files 696

Run time 1min

Badge

Embed ▾

Committed 03 Nov 2026 03:24AM UTC coverage: 89.449% (+0.007%) from 89.442%

Build # #20551

Build Type

push

github

Committed by

web-flow

Commit Message

xds: Fix intermittent failure in RingHashLoadBalancerTest.allSubchannelsInTransientFailure (#13130)

Deliver TRANSIENT_FAILURE in deterministic server order using
subchannelList instead of iterating over subchannels.values() (HashMap),
and expect 2 connections.

Why this became flaky with the new PickFirst LB:
Old PickFirst unconditionally invoked subchannel.requestConnection() on
each call without checking connection state, so triggering proactive
connections twice always produced 2 connection requests regardless of
iteration order (either [A, B] or [A, A]).

New PickFirst deduplicates connection requests if a subchannel is
already in CONNECTING state. When iterating over a HashMap, if the same
subchannel was triggered twice, New PickFirst deduplicated it to 1
connection, leading to the assumption in #13094 that New PickFirst would
always yield 1 connection. However, if two distinct subchannels were
triggered (e.g. server1 then server2), New PickFirst does not
deduplicate and yields 2 connections, causing verifyConnection(1) to
fail intermittently.

Fix this by iterating deterministically in server order, which reliably
triggers two distinct subchannels (server1 and server2) in both old and
new PickFirst.

Failure test run in fusion2/d9446b33-dc0e-4dee-b901-ea9b3b57f3c6

Coverage Stats

39413 of 44062 relevant lines covered (89.45%)

0.89 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	95.0	-1.0%	../core/src/main/java/io/grpc/internal/ServerCallImpl.java
2	81.05	0.0%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2	97.43	0.2%	../xds/src/main/java/io/grpc/xds/ExternalProcessorClientInterceptor.java
1	90.97	-0.35%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1	87.63	-0.21%	../inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java
1	87.88	-3.03%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
1	78.45	1.72%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20551.1	03 Nov 2026 03:37AM UTC	696	89.45

grpc / grpc-java / #20551
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20551

grpc / grpc-java / #20551 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20551

grpc / grpc-java / #20551
89%

README BADGES
x