solidjs / solid / 41565219781

79%

main: 89%

push

github

fix(signals): a second guess shows beside the first action's re-ask (#4629, memo) (#4637)

* fix(signals): seat a held pending reader of a re-guess in the lane from its first read (#4629)

A body-end correction re-homes an overlay memo into its action's hold,
pending on the action's refresh. A second action's guess into the same
slot opened a new lane, but the overlay's re-run started as the hold's
work and threw on the pending list before reaching the guess read that
would have moved it into the lane. Readers the lane's parent holds
pending are now listed in the lane before the pass, so lane work reads
the parent's flight as the screen (D-26, D-37) in either read order
(D-28).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* test(signals): #4629 frame (4) now passes in both shapes

With #4633 (projection) and this fix (memo), the second guess shows at once
beside the screen's issues (D-26): the it.fails rows become plain rows and
the D-26 known-deviation note becomes a fixed note.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* fix(signals): seat the held re-ask reader at every lane node's change (#4629)

The seating loop ran only over the guessed node's direct subscribers, so a
held pending pass reading the guess through a derived memo (byId) was still
thrown back into the hold at frame (4). Moved into laneDirty, which runs at
the guess and at each lane node's change (core and store), so the pass is
seated whatever depth it reads the guess at (D-26, D-37, D-28). Smaller than
the direct-only loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

---------

Co-authored-by: Claude <noreply@anthropic.com>

803 of 1104 branches covered (72.74%)

Branch coverage included in aggregate %.

1131 of 1369 relevant lines covered (82.62%)

29.95 hits per line