solidjs / solid / 41548385154

78%

main: 89%

push

github

fix(signals): an Errored recovery re-arms the Loadings under it (#4627) (#4634)

* fix(signals): an Errored recovery re-arms the Loadings under it (#4627)

While an <Errored> shows its fallback nothing under it is on screen, so
every <Loading> under it counts as not shown. On recovery each catches what
is still pending in the replacement frame and shows its fallback beside the
recovered content. The error still stays up for the errored source's own
re-ask, a pending read directly under the Errored, and a held recovery.

Re-rules async-gen 91501 #1831 (D-39, ruled 2026-11-02) and fixes the
#4425 known-bug spec.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* test: an Errored recovery's re-arm shows the inner Loading's fallback (#4627)

The derived-store recovery rows (seed 3289, the #1831 store twin) and the
#4592 inside-Loading rows follow the 2026-11-02 ruling: the errored source
answers, and what is still pending is caught by the re-armed Loading (D-39,
F-4). Held in an action, the error stays through the hold (D-41). The
no-boundary #4592 rows keep the error (a pending is not a value).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* fix(signals): type the caughtBelow boundary walk

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* perf(signals): re-arm Loadings behind an error fallback where they are asked

Drops the child-boundary tracking (`_kids`, `unshow`, `reshow`): a
loading boundary behind a shown error fallback is collecting, and is reset
to not-shown when asked (`isCollecting`). Same screens; about half the
bytes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* fix(signals): keep the error up while a re-armed Loa... (continued)

803 of 1104 branches covered (72.74%)

Branch coverage included in aggregate %.

1131 of 1369 relevant lines covered (82.62%)

30.04 hits per line