IJHack / QtPass / 41538528078

93%

push

github

Settings: warn when pass would commit to a repository above the store (#2119)

* Settings: warn when pass would commit to a repository above the store

pass fences git in with GIT_CEILING_DIRECTORIES="$PREFIX/.." and
unsets GIT_DIR and GIT_WORK_TREE, so QtPass cannot pin it as it pins
native Git (#2086). git splits the ceiling on ":", so a colon anywhere
in the store's path, also in the store folder's own name, leaves no
ceiling at the parent: a store without its own repository then finds
one above it, and pass adds and commits every change there, whether
or not QtPass uses Git.

Util::repositoryPassClimbsTo() names that repository. Settings shows
a warning under the pass options while the pass backend is chosen,
for the active store and each profile's store.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* chore: update localization source references

make lupdate for the new Settings warning; locations and one new
unfinished entry per locale.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Util: resolve a missing store from its nearest existing folder

repositoryPassClimbsTo() fell back to the absolute spelling for a store
that does not exist yet, so a link above it stayed in the path: on
macOS the temporary folder is under /var, a link to /private/var, and
the test failed there. The nearest existing folder is now resolved and
the rest appended; a new test case spells the store through a link, so
Linux catches it too.

The test also strips every repository-location variable pass unsets,
so an inherited GIT_COMMON_DIR or GIT_INDEX_FILE cannot stand in for
the temporary repositories (CodeRabbit).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claud... (continued)

83 of 84 new or added lines in 2 files covered. (98.81%)

10242 of 11052 relevant lines covered (92.67%)

397.44 hits per line