IJHack / QtPass / 41511182230

93%

Build Type

push

github

Committed by web-flow

Commit Message

PasswordDialog: copies out of the editor are marked and autocleared (#2117)

* PasswordDialog: copies out of the editor are marked and autocleared

The password editor showed the decrypted entry in plain QLineEdits and
a QPlainTextEdit, so Ctrl+C, Ctrl+X, the context menu and the X11
primary selection put it on the clipboard without the secret hints
(clipboard history kept it) and autoclear never cleared it (#2054).

- The body is a SecretPlainTextEdit: createMimeDataFromSelection()
  covers every way text leaves it, as in SecretTextBrowser.
- The password and the field lines are SecretLineEdits. In an editable
  field Ctrl+X and Cut now copy marked before they delete. Password
  mode, which keeps the read-only display from making a plain
  selection copy, would turn off undo, make word moves jump to the
  ends and change the input method hints, so there the marked
  selection replaces QLineEdit's plain one in the same event instead.
- PasswordDialog::copied() reports every copy; MainWindow passes it to
  ClipboardManager::trackCopied().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* SecretLineEdit: mark what line deletes copy; keep OTP field reporting

- QLineEdit copies what DeleteEndOfLine and DeleteCompleteLine delete
  (Ctrl+K, Ctrl+U with the X11 key bindings), unmarked. They now cut
  through the secret copy; read-only they do nothing, as in QLineEdit.
- hookOtpField() dropped every connection from a field that lost the
  OTP role, its copy reporting with them. Only the three OTP hooks go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

38 of 43 new or added lines in 4 files covered. (88.37%)

12 existing lines in 1 file now uncovered.

10159 of 10968 relevant lines covered (92.62%)

398.65 hits per line