IJHack / QtPass / 41482438544

93%

Build Type

push

github

Committed by web-flow

Commit Message

Pass: name refuseLinkedPath()'s two flags (#2114)

* Pass: name refuseLinkedPath()'s two flags

refuseLinkedPath(x, true, true) said nothing at the call site. The two
bools become scoped enums: LinkScope (EntryAndParents, or ParentsOnly
for a removal) and PathSpelling (Configured, or PlacedByCaller for
Init()). Both Init()s use a local refusePlaced() for their three
checks. No change in behaviour.

New tests: a removal judges only the folders above a link, and the
target-spelling warning comes for a Configured path and not for a
placed one (it had no test through refuseLinkedPath() before).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* tests: spell the target path canonically in the warning test

Where the temporary directory lies behind a link (/var on macOS), the
plain target path is under neither spelling of the store root, so no
warning came and ignoreMessage() failed. Build it from the canonical
target, as the link resolves. Checked with TMPDIR behind a link: the
old test fails there, this one passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

14 of 14 new or added lines in 3 files covered. (100.0%)

7 existing lines in 1 file now uncovered.

10089 of 10883 relevant lines covered (92.7%)

397.97 hits per line