karpetrosyan / hishel / 41459737467

98%

push

github

fix: ignore a malformed Range header instead of crashing the request (#496)

* fix: ignore a malformed Range header instead of raising

Range.try_from_str has a try-contract (Optional return, and the
multiple-ranges branch already returns None), but syntactically invalid
inputs ('bytes', 'bytes=x-y', ...) raised ValueError out of the cache
state machine, failing the request before it reached the transport.
RFC 9110 14.2 requires recipients to ignore an invalid ranges-specifier.

* Annotate the new test's return type for mypy

53 of 53 new or added lines in 4 files covered. (100.0%)

4863 of 5352 relevant lines covered (90.86%)

4.54 hits per line