kubernetes-sigs / lws / 41410973221

88%

push

github

DisaggregatedSet: budget External roles for a large group index in generated names (#1242)

* DisaggregatedSet: budget External roles for a large group index in generated names

Admission sized the group index in generated names from spec.replicas,
which External roles ignore. When an autoscaler later grew an External
role past ten groups, the worker StatefulSet's controller-revision-hash
label could exceed 63 characters and its Pods could not be created.

A role or sub-role that becomes External, or an External one that leaves
groupIdentity Hash and so gains a group index in its names, now reserves
8 digits for the index by default, as many as a hash group key takes.
External and Hash roles therefore share one name limit, and replicas stay
uncapped. Roles that were already External keep their earlier budget, so
stored DisaggregatedSets remain updatable.

The new disaggregatedSetExternalGroupIndexDigits manager option changes
the reserved digits, for clusters that need longer names, including when
a DisaggregatedSet is deleted and created again.

* DisaggregatedSet: reserve a fixed group index budget for External roles

Remove the disaggregatedSetExternalGroupIndexDigits manager option. It added
permanent v1 API surface for a limit that groupIdentity Hash already fixes
without a setting, and stored DisaggregatedSets stay updatable without it.

External Hash roles no longer report a group index budget when rejected,
since their names contain no index. The reserved digits now act as a floor,
so they cannot shrink the budget of a larger static replica count.

* DisaggregatedSet: warn when existing External names limit the group count

The legacy exemption keeps stored DisaggregatedSets updatable, but those
roles can still produce a controller-revision-hash label over 63 characters
once an autoscaler passes the group count their names allow. Return an
admission warning with that count when it is below the reserved 8 digits.

Move the groupIdentity Hash ch... (continued)

60 of 60 new or added lines in 3 files covered. (100.0%)

9574 of 10818 relevant lines covered (88.5%)

35870.84 hits per line