kubernetes-sigs / lws / 41336172432

88%

Build Type

push

github

Committed by web-flow

Commit Message

DisaggregatedSet: report availability floors separately from rollout completion (#1233)

* DisaggregatedSet: report availability floors separately from rollout completion

Available is a completion signal and goes False on every rollout and
scale-up, even when no role drops below what maxUnavailable permits.
Publish the rollout planner's view of availability so health checks and
parent controllers do not have to reimplement it.

- RoleStatus/SubRoleStatus.minAvailableReplicas: per slice,
  max(0, desired - maxUnavailable), totalled across slices. Unset while
  the target is unknown.
- RoleStatus/SubRoleStatus.availableReplicas: Ready groups in a revision
  of a slice where every role that revision requires has a Ready group,
  matching the planner's usable capacity.
- MinimumReplicasAvailable condition: True while every role and sub-role
  meets its floor, False naming those below it, Unknown while a floor is
  unknown. Available and Progressing are unchanged.

Updates KEP-766 and the DisaggregatedSet docs.

* DisaggregatedSet: judge availability from targets and recorded layouts

The current revision required only roles that had a workload, so a Ready
role stayed available while a peer's workload was missing. It now requires
every role with a positive target in each slice.

Workloads the spec does not partition counted as one role even when they
carry an old child layout, so an old revision with an unready child still
counted as serving. Requirements now come from the recorded layout, for
parents that dropped their sub-roles and for removed roles alike.

A known shortfall now reports False even while another floor is unknown.
Role lists in condition messages are capped, because an overlong message
made the API reject the whole status update.

* DisaggregatedSet: test that available replicas never exceed ready replicas

* DisaggregatedSet: require targets, not recorded layouts, on the current revision

Sub-roles do not change the revision, so they cha... (continued)

Coverage Stats

187 of 197 new or added lines in 1 file covered. (94.92%)

2 existing lines in 1 file now uncovered.

9530 of 10774 relevant lines covered (88.45%)

36015.66 hits per line