cameri / nats-server / 41389968540
78%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.543% (+6.3%) from 76.276%
41389968540

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

71344 of 86433 relevant lines covered (82.54%)

336262.45 hits per line

Coverage Regressions

Lines Coverage ∆ File
55
82.91
-0.25% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
25
79.49
1.18% src/github.com/nats-io/nats-server/server/raft.go
21
87.45
0.15% src/github.com/nats-io/nats-server/server/consumer.go
13
73.82
0.33% src/github.com/nats-io/nats-server/server/jetstream_api.go
11
86.16
0.06% src/github.com/nats-io/nats-server/server/accounts.go
11
78.16
0.09% src/github.com/nats-io/nats-server/server/filestore.go
7
86.06
0.6% src/github.com/nats-io/nats-server/server/stream.go
6
93.43
0.0% src/github.com/nats-io/nats-server/server/gateway.go
5
67.46
15.64% src/github.com/nats-io/nats-server/server/reload.go
5
89.29
3.55% src/github.com/nats-io/nats-server/server/server.go
4
85.23
1.38% src/github.com/nats-io/nats-server/server/events.go
4
77.84
15.73% src/github.com/nats-io/nats-server/server/opts.go
4
84.59
3.03% src/github.com/nats-io/nats-server/server/route.go
1
92.86
4.22% src/github.com/nats-io/nats-server/server/client.go
1
86.38
0.47% src/github.com/nats-io/nats-server/server/util.go
Jobs
ID Job ID Ran Files Coverage
1 41389968540.1 66
82.54
GitHub Action Run
Source Files on build 41389968540