cameri / nats-server / 41274177292
78%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.276% (-5.0%) from 81.241%
41274177292

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

65928 of 86433 relevant lines covered (76.28%)

247194.98 hits per line

Coverage Regressions

Lines Coverage ∆ File
2430
24.45
-64.1% src/github.com/nats-io/nats-server/server/mqtt.go
445
69.92
-16.52% src/github.com/nats-io/nats-server/server/monitor.go
210
71.43
-9.9% src/github.com/nats-io/nats-server/server/memstore.go
202
47.1
-18.88% src/github.com/nats-io/nats-server/server/websocket.go
177
82.01
-7.39% src/github.com/nats-io/nats-server/server/leafnode.go
156
51.81
-9.45% src/github.com/nats-io/nats-server/server/reload.go
112
44.85
-24.03% src/github.com/nats-io/nats-server/server/msgtrace.go
112
0.0
-52.83% src/github.com/nats-io/nats-server/server/proto.go
103
88.65
-2.51% src/github.com/nats-io/nats-server/server/client.go
81
62.11
-1.72% src/github.com/nats-io/nats-server/server/opts.go
79
85.75
-2.7% src/github.com/nats-io/nats-server/server/server.go
46
83.16
0.03% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
45
82.87
-3.78% src/github.com/nats-io/nats-server/server/auth.go
34
8.11
-91.89% src/github.com/nats-io/nats-server/server/monitor_sort_opts.go
31
73.49
-0.54% src/github.com/nats-io/nats-server/server/jetstream_api.go
29
54.72
-18.24% src/github.com/nats-io/nats-server/server/log.go
21
87.29
-0.02% src/github.com/nats-io/nats-server/server/consumer.go
20
81.43
-2.69% src/github.com/nats-io/nats-server/server/parser.go
20
78.32
0.26% src/github.com/nats-io/nats-server/server/raft.go
18
83.85
-0.71% src/github.com/nats-io/nats-server/server/events.go
18
88.78
-1.71% src/github.com/nats-io/nats-server/server/sublist.go
17
78.07
-0.08% src/github.com/nats-io/nats-server/server/filestore.go
14
85.46
-0.11% src/github.com/nats-io/nats-server/server/stream.go
13
81.56
-0.61% src/github.com/nats-io/nats-server/server/route.go
9
70.49
-14.75% src/github.com/nats-io/nats-server/server/feature_flags.go
4
84.39
-0.2% src/github.com/nats-io/nats-server/server/jetstream.go
2
93.43
0.1% src/github.com/nats-io/nats-server/server/gateway.go
2
55.36
-0.14% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
2
98.44
-1.56% src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2
85.92
-0.47% src/github.com/nats-io/nats-server/server/util.go
Jobs
ID Job ID Ran Files Coverage
1 41274177292.1 66
76.28
GitHub Action Run
Source Files on build 41274177292