mindersec / minder / 41349626190

67%

push

github

fix(controlplane): make ArtifactPk consistently the entity UUID (#7055)

Make ArtifactPk consistently the entity UUID

GetArtifactByName and GetArtifactById set ArtifactPk to upstream_id,
while ListArtifacts sets it to the entity UUID -- so the same
artifact's ID means different things depending on which endpoint
returned it, and the UUID-shaped artifact get --id can't accept the
ID that GetArtifactByName just returned.

Confirmed the resulting break: minder artifact get sends ArtifactPk
as the entity ID to GetProfileStatusByName, which calls uuid.Parse on
it server-side. For a DockerHub/Quay/GitHub artifact, that value is
upstream_id or a package ID, not a UUID, so the call fails with
InvalidArgument. Reproduced this against the real
GetProfileStatusByName handler before fixing it.

Fixes this in the two handlers (GetArtifactByName, GetArtifactById):
ArtifactPk is now set to the entity UUID after converting to proto,
matching ListArtifacts. Provider code is untouched -- it still writes
upstream_id into properties, the handler now overwrites it in the
response.

Also fixes the test fixture that masked this: mock_artifact_get.json
used a placeholder ID ("111") that the mocked
GetProfileStatusByName(gomock.Any(), ...) never checked, so the CLI
test never exercised the real value. Fixture now uses a real-shaped
UUID, and the mock asserts the exact ID it receives.

Fixes #7050

2 of 2 new or added lines in 1 file covered. (100.0%)

23201 of 35468 relevant lines covered (65.41%)

58.46 hits per line