solidjs / solid / 41319505034

78%

main: 89%

push

github

fix(signals): latest() and isPending() in a hydration claim read the server's snapshot (#4570) (#4581)

* fix(signals): latest() and isPending() in a hydration claim read the server's snapshot (#4570)

A client write during the hydration window, while a streamed boundary is
still out, re-arms a <Loading on> nested in it. When the server's answer
streams in, the boundary resumes in a snapshot scope: a plain read is
served the value the server rendered with, but latest() and isPending()
read through the verdict window, which did not serve it. latest(a1) beside
a1() saw the client's flight (a1:1, no value yet), threw, and put the inner
boundary in a fallback the server never rendered, claimed against nothing:
"Hydration key miss", a detached <p>F1</p>, and F1 beside the snapshot's
a1=10 (F-1; D-16 says that re-arm's fallback never shows).

verdictValue now serves the snapshot to a reader in a snapshot scope, as
read() does, marking it stale so it replays at the scope's release. The
code is in the verdict engine: apps without latest/isPending pay nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(signals): one snapshot-serve helper for read() and the verdict window (#4570)

The verdict window's copy of read()'s snapshot serve cost the live pages
125-159 B minified. Both sites now call one helper, servedSnapshot, behind
the same inline guard, so builds that never hydrate still fold both away.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* Revert "perf(signals): one snapshot-serve helper for read() and the verdict window (#4570)"

This reverts commit d1000a81f.

* perf(signals): re-run a claim's verdict reader at release without comparing (#4570)

A verdict reader served the server's snapshot in a hydration claim is
marked stale unconditionally; read... (continued)

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

29.9 hits per line