solidjs / solid / 41317679768

78%

main: 89%

push

github

fix(signals): a guess over a question in flight keeps the frame whole with a memo between the list and its binding (#4561) (#4572)

* fix(signals): a guess over a question in flight keeps the frame whole with a memo between the list and its binding (#4561)

#4558 kept a render effect in the frame's hold observing the flight a list
guess was written over, but a derivation between the list and its binding
(a memo, a mapArray) was served the guess as standing in for the flight,
stopped waiting on it, and the binding followed it out of the hold: the
frame committed `closed` beside the open answer's rows (F-1, D-34 ¶3).

The optimistic `stands` hook now treats a derivation a pending render
effect reads as part of the hold (scheduler `blockedBy`), as 075bcafe7's
gate did: over a held flight it stays linked as a stale reader of the hold
and is still served the guess, so a <For> keeps showing it (#4525) while
the hold keeps its frame; over a flight no transaction holds (a `Loading
on` fallback) it reads the derive plainly. A flat memo over every row may
keep waiting with the old answer instead of showing the guess (F-2), as
#4536's shared-binding test allows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(signals): trim the #4561 hold gate to the derivation walk (−31 B minified)

A render effect is read before the gate, so `held` only walks a
derivation's subscribers for a pending render effect. Same behaviour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): judge the #4561 hold through derivation chains, once per pass

- `held` walks pending derivations transitively (memo -> memo -> binding,
  mapArray -> memo -> binding) to a pending render effect, as scheduler
  `blockedBy` judges the frame's hold (F-1).
- A reader this pass linked as a stale reader of the hold keeps the ... (continued)

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

29.83 hits per line