• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 41306794410
85%

Build:
DEFAULT BRANCH: main
Ran 01 Nov 2026 12:39PM UTC
Jobs 100
Files 625
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Nov 2026 12:30PM UTC coverage: 84.678% (-0.02%) from 84.699%
41306794410

push

github

Effi-S
fix(fabricx): stop leaking the finality goroutine on broadcast error

In `fnsBroadcaster.Broadcast`, the finality channel was unbuffered and the
polling goroutine ran `final <- getFinality(...)`. When
`fns.Ordering().Broadcast(...)` failed, the function returned without ever
reading `<-final`, so the goroutine blocked forever on its send and leaked
permanently. Repeated submit failures accumulated one leaked goroutine each,
along with up to 10s of pointless finality polling per leak.

Buffer the finality channel so the send can always complete, and derive a
cancellable context that is cancelled on return so an orphaned poller stops
promptly instead of running out its retry budget with nobody listening.
`getFinality` now takes that context, passes it to `IsFinal`, and waits on a
`select` over `ctx.Done()` and the retry timer rather than a blind
`time.Sleep`; it also skips the trailing sleep after the final attempt.

The broadcast logic moves into `broadcastAndWaitForFinality`, behind a small
consumer-side `ordering` interface, so it is unit-testable without a full
`fabric.NetworkServiceProvider`. The exported `EnvelopeBroadcaster` and
`Submitter` interfaces are unchanged, so there is no ripple into callers.

Tests cover the `getFinality` retry matrix, early cancellation, and the
success and finality-error paths, plus two `goleak` regression tests for the
broadcast-error path. Both fail against the previous implementation with
goroutines parked in the finality poller.

Fixes #2559

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Akram Bitar <akram@il.ibm.com>

19 of 20 new or added lines in 1 file covered. (95.0%)

50 existing lines in 12 files now uncovered.

47981 of 56663 relevant lines covered (84.68%)

28329.85 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
59.65
59.65% token/services/network/fabricx/tms/common.go

Coverage Regressions

Lines Coverage ∆ File
22
55.14
-3.71% token/services/storage/db/common/checks.go
4
81.97
-6.56% token/services/selector/sherdlock/service.go
4
75.42
-1.33% token/services/storage/ttxdb/store.go
4
82.75
0.0% token/services/storage/db/sql/common/transactions.go
2
83.67
-0.14% token/services/storage/db/sql/common/tokens.go
2
90.81
-0.45% token/services/selector/sherdlock/selector.go
2
87.3
-1.06% token/services/storage/db/sql/common/findings.go
2
88.47
-0.36% token/services/benchmark/runner.go
2
72.73
-9.09% token/services/storage/db/manager.go
2
77.1
-0.76% token/services/ttx/transaction.go
2
88.0
-1.14% token/services/storage/db/sql/postgres/tokenlock.go
2
74.39
-1.22% token/services/storage/db/sql/sqlite/driver.go
Jobs
ID Job ID Ran Files Coverage
1 itest-evm-t13 - 41306794410.1 01 Nov 2026 12:41PM UTC 563
34.37
GitHub Action Run
2 itest-evm-gateway-t6 - 41306794410.2 01 Nov 2026 12:48PM UTC 563
41.24
GitHub Action Run
3 itest-evm-gateway-fabtoken-t2 - 41306794410.3 01 Nov 2026 12:40PM UTC 563
10.42
GitHub Action Run
4 itest-fabtoken-fabric-t1-websocket - 41306794410.4 01 Nov 2026 12:47PM UTC 522
36.19
GitHub Action Run
5 itest-interop-dlog-t5 - 41306794410.5 01 Nov 2026 12:43PM UTC 522
41.23
GitHub Action Run
6 itest-dlogstress-t1 - 41306794410.6 01 Nov 2026 12:41PM UTC 522
39.35
GitHub Action Run
7 itest-dlog-fabric-t2.1 - 41306794410.7 01 Nov 2026 12:44PM UTC 522
35.09
GitHub Action Run
8 itest-evm-gateway-fabtoken-t13 - 41306794410.8 01 Nov 2026 12:40PM UTC 563
28.37
GitHub Action Run
9 itest-update-t1 - 41306794410.9 01 Nov 2026 12:48PM UTC 522
43.29
GitHub Action Run
10 itest-interop-dlog-t4 - 41306794410.10 01 Nov 2026 12:46PM UTC 522
41.19
GitHub Action Run
11 itest-dlog-fabric-t1-libp2p - 41306794410.11 01 Nov 2026 12:49PM UTC 522
43.55
GitHub Action Run
12 itest-dlog-fabric-t6-websocket - 41306794410.12 01 Nov 2026 12:48PM UTC 522
43.82
GitHub Action Run
13 itest-dlog-fabric-t10-websocket - 41306794410.13 01 Nov 2026 12:49PM UTC 522
44.46
GitHub Action Run
14 itest-fabtoken-fabric-t3 - 41306794410.14 01 Nov 2026 12:43PM UTC 522
31.83
GitHub Action Run
15 itest-fabtoken-fabric-t1-replicas - 41306794410.15 01 Nov 2026 12:48PM UTC 522
38.24
GitHub Action Run
16 utest-unit-tests-race - 41306794410.16 01 Nov 2026 12:47PM UTC 624
76.54
GitHub Action Run
17 itest-dlog-fabric-t1-replicas - 41306794410.17 01 Nov 2026 12:47PM UTC 522
45.61
GitHub Action Run
18 itest-dloghsm-fabric-t2-libp2p - 41306794410.18 01 Nov 2026 12:50PM UTC 523
43.82
GitHub Action Run
19 itest-fabtoken-fabric-t17 - 41306794410.19 01 Nov 2026 12:45PM UTC 522
32.06
GitHub Action Run
20 itest-dlog-fabric-t9 - 41306794410.20 01 Nov 2026 12:45PM UTC 522
36.59
GitHub Action Run
21 itest-evm-fabtoken-t9 - 41306794410.21 01 Nov 2026 12:39PM UTC 563
26.43
GitHub Action Run
22 itest-evm-gateway-t9 - 41306794410.22 01 Nov 2026 12:39PM UTC 563
32.94
GitHub Action Run
23 itest-fabricx-dlog-t1-libp2p - 41306794410.23 01 Nov 2026 12:53PM UTC 542
43.06
GitHub Action Run
24 itest-evm-gateway-t1 - 41306794410.24 01 Nov 2026 12:48PM UTC 563
41.01
GitHub Action Run
25 itest-evm-fabtoken-t13 - 41306794410.25 01 Nov 2026 12:40PM UTC 563
28.05
GitHub Action Run
26 itest-evm-gateway-t2.1 - 41306794410.26 01 Nov 2026 12:40PM UTC 563
31.61
GitHub Action Run
27 itest-fabricx-dlog-t16-libp2p - 41306794410.27 01 Nov 2026 12:53PM UTC 542
43.25
GitHub Action Run
28 itest-interop-fabtoken-t1 - 41306794410.28 01 Nov 2026 12:48PM UTC 522
35.52
GitHub Action Run
29 itest-evm-gateway-t12 - 41306794410.29 01 Nov 2026 12:41PM UTC 563
37.65
GitHub Action Run
30 itest-update-t2 - 41306794410.30 01 Nov 2026 12:46PM UTC 522
38.8
GitHub Action Run
31 itest-dlog-fabric-t13 - 41306794410.31 01 Nov 2026 12:44PM UTC 522
38.42
GitHub Action Run
32 itest-evm-gateway-t13 - 41306794410.32 01 Nov 2026 12:40PM UTC 563
34.69
GitHub Action Run
33 itest-evm-t6 - 41306794410.33 01 Nov 2026 12:46PM UTC 563
41.31
GitHub Action Run
34 itest-fabricx-dlog-t6-replicas - 41306794410.34 01 Nov 2026 12:54PM UTC 542
45.22
GitHub Action Run
35 itest-nft-dlog - 41306794410.35 01 Nov 2026 12:43PM UTC 530
38.93
GitHub Action Run
36 itest-dvp-dlog - 41306794410.36 01 Nov 2026 12:44PM UTC 530
40.39
GitHub Action Run
37 itest-fabricx-dlog-t11 - 41306794410.37 01 Nov 2026 12:46PM UTC 542
34.09
GitHub Action Run
38 itest-interop-dlog-t1 - 41306794410.38 01 Nov 2026 12:48PM UTC 522
42.88
GitHub Action Run
39 itest-fabtoken-fabric-t1-libp2p - 41306794410.39 01 Nov 2026 12:47PM UTC 522
36.15
GitHub Action Run
40 itest-dlog-fabric-t2 - 41306794410.40 01 Nov 2026 12:46PM UTC 522
35.26
GitHub Action Run
41 itest-evm-fabtoken-t1 - 41306794410.41 01 Nov 2026 12:48PM UTC 563
33.99
GitHub Action Run
42 itest-interop-dlog-t3 - 41306794410.42 01 Nov 2026 12:45PM UTC 522
41.77
GitHub Action Run
43 itest-dloghsm-fabric-t2-websocket - 41306794410.43 01 Nov 2026 12:48PM UTC 523
43.86
GitHub Action Run
44 itest-evm-gateway-fabtoken-t6 - 41306794410.44 01 Nov 2026 12:48PM UTC 563
34.61
GitHub Action Run
45 itest-evm-t2.1 - 41306794410.45 01 Nov 2026 12:40PM UTC 563
31.52
GitHub Action Run
46 itest-evm-t12 - 41306794410.46 01 Nov 2026 12:40PM UTC 563
37.44
GitHub Action Run
47 itest-evm-gateway-t11 - 41306794410.47 01 Nov 2026 12:47PM UTC 563
33.09
GitHub Action Run
48 itest-dloghsm-fabric-t1-replicas - 41306794410.48 01 Nov 2026 12:48PM UTC 523
45.65
GitHub Action Run
49 itest-fabtoken-fabric-t2 - 41306794410.49 01 Nov 2026 12:45PM UTC 522
29.5
GitHub Action Run
50 itest-evm-t11 - 41306794410.50 01 Nov 2026 12:47PM UTC 563
32.48
GitHub Action Run
51 itest-fabricx-dlog-t6-websocket - 41306794410.51 01 Nov 2026 12:53PM UTC 542
43.3
GitHub Action Run
52 itest-interop-fabtoken-t4 - 41306794410.52 01 Nov 2026 12:46PM UTC 522
33.85
GitHub Action Run
53 itest-dloghsm-fabric-t1-websocket - 41306794410.53 01 Nov 2026 12:50PM UTC 523
43.6
GitHub Action Run
54 itest-dlog-fabric-t10-replicas - 41306794410.54 01 Nov 2026 12:51PM UTC 522
46.49
GitHub Action Run
55 itest-fabricx-dlog-t16-replicas - 41306794410.55 01 Nov 2026 12:55PM UTC 542
45.15
GitHub Action Run
56 itest-dlog-fabric-t7 - 41306794410.56 01 Nov 2026 12:46PM UTC 522
35.46
GitHub Action Run
57 itest-fabricx-dlog-t6-libp2p - 41306794410.57 01 Nov 2026 12:52PM UTC 542
43.3
GitHub Action Run
58 itest-dlog-fabric-t10-libp2p - 41306794410.58 01 Nov 2026 12:50PM UTC 522
44.41
GitHub Action Run
59 itest-interop-fabtoken-t5 - 41306794410.59 01 Nov 2026 12:46PM UTC 522
33.88
GitHub Action Run
60 itest-dloghsm-fabric-t2-replicas - 41306794410.60 01 Nov 2026 12:51PM UTC 523
45.9
GitHub Action Run
61 itest-dlog-fabric-t5 - 41306794410.61 01 Nov 2026 12:46PM UTC 522
40.57
GitHub Action Run
62 itest-fabricx-dlog-t5 - 41306794410.62 01 Nov 2026 12:45PM UTC 542
40.65
GitHub Action Run
63 itest-update-t3 - 41306794410.63 01 Nov 2026 12:51PM UTC 522
39.4
GitHub Action Run
64 itest-evm-gateway-t2 - 41306794410.64 01 Nov 2026 12:40PM UTC 563
31.9
GitHub Action Run
65 itest-evm-gateway-fabtoken-t11 - 41306794410.65 01 Nov 2026 12:46PM UTC 563
27.81
GitHub Action Run
66 itest-dloghsm-fabric-t1-libp2p - 41306794410.66 01 Nov 2026 12:49PM UTC 523
43.58
GitHub Action Run
67 itest-evm-gateway-fabtoken-t9 - 41306794410.67 01 Nov 2026 12:40PM UTC 563
26.3
GitHub Action Run
68 itest-dlog-fabric-t6-libp2p - 41306794410.68 01 Nov 2026 12:47PM UTC 522
43.78
GitHub Action Run
69 itest-fabricx-dlog-t1-websocket - 41306794410.69 01 Nov 2026 12:53PM UTC 542
43.07
GitHub Action Run
70 itest-nft-fabtoken - 41306794410.70 01 Nov 2026 12:42PM UTC 530
31.73
GitHub Action Run
71 itest-fabricx-dlog-t4 - 41306794410.71 01 Nov 2026 12:44PM UTC 542
40.64
GitHub Action Run
72 itest-fabricx-dlog-t3 - 41306794410.72 01 Nov 2026 12:45PM UTC 542
38.32
GitHub Action Run
73 itest-interop-fabtoken-t3 - 41306794410.73 01 Nov 2026 12:44PM UTC 522
34.41
GitHub Action Run
74 itest-dlog-fabric-t15 - 41306794410.74 01 Nov 2026 12:50PM UTC 522
43.61
GitHub Action Run
75 itest-dlog-fabric-t4 - 41306794410.75 01 Nov 2026 12:46PM UTC 522
40.69
GitHub Action Run
76 utest-unit-tests-regression - 41306794410.76 01 Nov 2026 12:47PM UTC 624
76.5
GitHub Action Run
77 itest-fabtoken-fabric-t5 - 41306794410.77 01 Nov 2026 12:45PM UTC 522
33.41
GitHub Action Run
78 itest-fabtoken-fabric-t4 - 41306794410.78 01 Nov 2026 12:45PM UTC 522
33.33
GitHub Action Run
79 itest-update-t4 - 41306794410.79 01 Nov 2026 12:47PM UTC 522
43.27
GitHub Action Run
80 itest-dlog-fabric-t3 - 41306794410.80 01 Nov 2026 12:44PM UTC 522
38.99
GitHub Action Run
81 itest-fabtoken-dlog-fabric - 41306794410.81 01 Nov 2026 12:54PM UTC 522
43.63
GitHub Action Run
82 itest-dvp-fabtoken - 41306794410.82 01 Nov 2026 12:44PM UTC 530
33.22
GitHub Action Run
83 itest-dlog-fabric-t8-libp2p - 41306794410.83 01 Nov 2026 12:49PM UTC 522
43.6
GitHub Action Run
84 itest-dlog-fabric-t6-replicas - 41306794410.84 01 Nov 2026 12:50PM UTC 522
45.83
GitHub Action Run
85 itest-dlog-fabric-t8-replicas - 41306794410.85 01 Nov 2026 12:50PM UTC 522
45.71
GitHub Action Run
86 itest-evm-fabtoken-t2 - 41306794410.86 01 Nov 2026 12:40PM UTC 563
26.25
GitHub Action Run
87 itest-evm-t2 - 41306794410.87 01 Nov 2026 12:40PM UTC 563
31.44
GitHub Action Run
88 itest-dlog-fabric-t17 - 41306794410.88 01 Nov 2026 12:46PM UTC 522
38.99
GitHub Action Run
89 itest-evm-t1 - 41306794410.89 01 Nov 2026 12:47PM UTC 563
41.18
GitHub Action Run
90 itest-fabricx-dlog-t13 - 41306794410.90 01 Nov 2026 12:46PM UTC 542
38.12
GitHub Action Run
91 itest-evm-gateway-fabtoken-t1 - 41306794410.91 01 Nov 2026 12:47PM UTC 563
34.26
GitHub Action Run
92 itest-evm-t9 - 41306794410.92 01 Nov 2026 12:40PM UTC 563
32.32
GitHub Action Run
93 itest-dlog-fabric-t12 - 41306794410.93 01 Nov 2026 12:44PM UTC 522
41.81
GitHub Action Run
94 itest-evm-fabtoken-t6 - 41306794410.94 01 Nov 2026 12:48PM UTC 563
34.63
GitHub Action Run
95 itest-dlog-fabric-t1-websocket - 41306794410.95 01 Nov 2026 12:49PM UTC 522
43.54
GitHub Action Run
96 itest-evm-fabtoken-t11 - 41306794410.96 01 Nov 2026 12:47PM UTC 563
27.2
GitHub Action Run
97 itest-dlog-fabric-t11 - 41306794410.97 01 Nov 2026 12:48PM UTC 522
34.53
GitHub Action Run
98 itest-fabricx-dlog-t1-replicas - 41306794410.98 01 Nov 2026 12:52PM UTC 542
44.94
GitHub Action Run
99 itest-fabricx-dlog-t16-websocket - 41306794410.99 01 Nov 2026 12:54PM UTC 542
43.25
GitHub Action Run
100 itest-dlog-fabric-t8-websocket - 41306794410.100 01 Nov 2026 12:49PM UTC 522
43.61
GitHub Action Run
Source Files on build 41306794410
  • Tree
  • List 625
  • Changed 82
  • Source Changed 1
  • Coverage Changed 82
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #41306794410
  • 4290c97b on github
  • Prev Build on main (#41302411911)
  • Next Build on main (#41383227692)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc