• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 41383227692
85%

Build:
DEFAULT BRANCH: main
Ran 02 Nov 2026 03:51AM UTC
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
41383227692

push

github

Effi-S
fix(fabricx): stop leaking the finality goroutine on broadcast error

In `fnsBroadcaster.Broadcast`, the finality channel was unbuffered and the
polling goroutine ran `final <- getFinality(...)`. When
`fns.Ordering().Broadcast(...)` failed, the function returned without ever
reading `<-final`, so the goroutine blocked forever on its send and leaked
permanently. Repeated submit failures accumulated one leaked goroutine each,
along with up to 10s of pointless finality polling per leak.

Buffer the finality channel so the send can always complete, and derive a
cancellable context that is cancelled on return so an orphaned poller stops
promptly instead of running out its retry budget with nobody listening.
`getFinality` now takes that context, passes it to `IsFinal`, and waits on a
`select` over `ctx.Done()` and the retry timer rather than a blind
`time.Sleep`; it also skips the trailing sleep after the final attempt.

The broadcast logic moves into `broadcastAndWaitForFinality`, behind a small
consumer-side `ordering` interface, so it is unit-testable without a full
`fabric.NetworkServiceProvider`. The exported `EnvelopeBroadcaster` and
`Submitter` interfaces are unchanged, so there is no ripple into callers.

Tests cover the `getFinality` retry matrix, early cancellation, and the
success and finality-error paths, plus two `goleak` regression tests for the
broadcast-error path. Both fail against the previous implementation with
goroutines parked in the finality poller.

Fixes #2559

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Akram Bitar <akram@il.ibm.com>
Source Files on build 41383227692
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #41383227692
  • 4290c97b on github
  • Prev Build on main (#41302411911)
  • Next Build on main (#41394102607)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc