IJHack / QtPass / 41294590088

93%

push

github

Executor: optional deadline for blocking runs; safe.directory uses it (#2107)

The safe.directory query (#2102) ran its own QProcess to get a deadline,
so it skipped Executor::startProcess(): no detachFromTerminal(), no
child umask, the one git run unlike the rest. Give Executor's blocking
run an optional timeoutMs instead (the whole run, start included;
default none) and let the query use it again, with five seconds.

A run past its deadline ends as a cancelled one does: terminate(), a
grace period, kill(), and -1. The stop is shared by both paths now.

SECURITY.md also says that a relative safe.directory entry such as ".",
which git resolves against its working directory, trusts nothing in
QtPass (both from Henk on #2102, tracked in #2094).


Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

29 of 30 new or added lines in 2 files covered. (96.67%)

10087 of 10879 relevant lines covered (92.72%)

398.0 hits per line