solidjs / solid / 41268694647

78%

main: 89%

push

github

perf(size): shrink the floors to make room for #4535 (−177 B minified on hello world) (#4560)

* perf(size): share the dependent walks, dep clearing and event-walk hops

The three async dependent walks (settle, errored settle, release) share
one visited-set walker; clearDeps reuses trimStaleDeps; the delegated
event walk shares its parent hop and owner-boundary test. Drops checks
already implied by pendingSource, and escalate's prod-dead default.
Cold paths only; no behavior change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(size): fold the trailing hold guard into one expression

Same truth table as the if: a non-effect holds, an effect holds unless
freshHook answers CAUGHT_REARMED; freshHook is still read once. About
-1 B minified on the boundary rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): the shared settle walk keeps a diamond join's early return

walkDependents skipped a node an earlier branch had walked before calling
the settle callback, so a diamond's join no longer took the settle walk's
early-return branch (a verdict reader's re-run, a staged error's mark) on
its second arrival. The callback now sees every arrival with a `seen`
flag; the release and errored walks ignore revisits as before. Pinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(size): notifyStatus writes the status flags once; setPendingError picks one error

notifyStatus's pending-source branch computed the same flags the general
formula gives a pending status; both branches now share it, the order of
writes otherwise unchanged (neither pending-source helper reads the
flags). setPendingError chooses the given, current or a fresh
NotReadyError in one expression — the same error lands in eve... (continued)

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

30.05 hits per line