solidjs / solid / 41255484942

78%

main: 89%

push

github

fix(signals): a re-pass equal to a staged first value is not a change (#4540) (#4555)

* fix(signals): a re-pass equal to a staged first value is not a change (#4540)

A node whose first value is staged in the running flush stays
STATUS_UNINITIALIZED until the commit, and recompute counted every
re-pass of it as a change. A non-keyed Show whose condition first
answers in a flush (an async memo or projection landing) re-ran its
value memo on each re-pass and remounted its child; a child writing the
source from its render effect's synchronous first run looped.

The uninitialized test now applies only when nothing is staged: with a
staged first value, the equality gate compares against it (INV-11), as
for any staged node.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): fold the #4540 staged check into the existing staged local

The first cut read `_pendingValue` again at the top of recompute and cost
+8 B minified on every core row. The equality gate already reads it for
compareValue and the effect gate reads it a third time; one `unstaged`
local now serves all three, and the uninitialized term checks it at the
gate. Core rows are back to +0 B minified, and the gate does one fewer
property load per pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): order the #4540 gate term for size

`unstaged && wasUninitialized && !isEffect`, with wasUninitialized kept as
the raw status bit, minifies 4 B smaller than the boolean-coerced form and
keeps the brotli rows under their caps. The `!!` moves to the observe-only
devChanged assignment, which needs a boolean. Same logic.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

29.95 hits per line