cameri / nostream / 41229750741

78%

push

github

test(payments): add unit tests for the zebedee, opennode, nodeless and lnurl processors (#917)



## Description
Adds unit specs for the four payment processors that had none, next to
the existing lnbits and nwc ones (`test/unit/payments-processors/`). No
production code changes.

For each processor:
- `createInvoice`: the request sent to the provider (url, body, amount
unit, callback url / metadata, ttl) and the mapping of the response to
an `Invoice`; msats are converted to whole sats where the provider takes
sats; provider outages and responses without data are not swallowed.
- `getInvoice`: the request, every provider status mapped to
`InvoiceStatus` (a status the provider adds later is never read as
paid), confirmation dates, and error propagation.
- processor specifics: OpenNode's `lightning_invoice` / `lightning`
fallback and `amount` / `price` fallback; Nodeless's 15 minute fallback
expiry; LNURL's generated invoice id and verify-url polling.

## Related Issue
Closes #903

## Motivation and Context
These are the money-moving code paths for four providers. A misread
status or a wrong amount unit is a funds bug, and nothing covered them.

## How Has This Been Tested?
- The new specs pass (58 tests). Reverting a status mapping in
`transform.ts` or changing OpenNode's ttl makes the matching spec fail.
- `pnpm lint`, `pnpm check:deps`, `pnpm run build:check`, `pnpm run
test:unit`.

## Screenshots (if appropriate):

## Types of changes
- [x] Non-functional change (docs, style, minor refactor)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the **CONTRIBUTING** document.
- [x] I have added tests to ... (continued)

4341 of 6162 branches covered (70.45%)

Branch coverage included in aggregate %.

9496 of 11759 relevant lines covered (80.76%)

778.32 hits per line